Skip to content

OSDOCS-11167: LVMS CSI and volume snapshot deployment is made optiona… #80995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

OSDOCS-11167: LVMS CSI and volume snapshot deployment is made optiona… #80995

merged 1 commit into from
Sep 23, 2024

Conversation

aravipra
Copy link
Contributor

@aravipra aravipra commented Aug 28, 2024 •
edited
Loading

Version(s):
4.17

Issue:
OSDOCS-11167

Link to docs preview:
LVMS CSI provider and CSI snapshot deployments are now configurable

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Additional information:
related to PR #80823

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11167 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-11167

Link to docs preview:

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 28, 2024 •
edited
Loading

🤖 Mon Sep 23 15:10:27 - Prow CI generated the docs preview:

https://80995--ocpdocs-pr.netlify.app/microshift/latest/microshift_release_notes/microshift-4-17-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11167 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-11167

Link to docs preview:
LVMS and volume snapshot deployment is now made optional

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@radeore
Copy link

radeore commented Aug 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 30, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11167 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-11167

Link to docs preview:
LVMS and volume snapshot deployment is now made optional

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 30, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11167 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-11167

Link to docs preview:
LVMS and volume snapshot deployment is now made optional

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Additional information:
related to PR #80823

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mffiedler
mffiedler approved these changes Aug 30, 2024
View reviewed changes
Copy link

@mffiedler mffiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@copejon
Copy link
Contributor

copejon commented Sep 3, 2024

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11167 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-11167

Link to docs preview:
LVMS and volume snapshot deployment is now made optional

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Additional information:
related to PR #80823

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 4, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11167 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-11167

Link to docs preview:
VMS CSI provider and CSI snapshot deployments are now configurable

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Additional information:
related to PR #80823

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added this to the Planned for 4.17 GA milestone Sep 12, 2024
@copejon
Copy link
Contributor

copejon commented Sep 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@aravipra
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 19, 2024
@cbippley
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 19, 2024
cbippley
cbippley reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits, and I can't check the xref since it is commented out, but otherwise LGTM!

@cbippley
Copy link
Contributor

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 19, 2024
@dhensel-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11167 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-11167

Link to docs preview:
VMS CSI provider and CSI snapshot deployments are now configurable

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Additional information:
related to PR #80823

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@ShaunaDiaz ShaunaDiaz removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@aravipra: This pull request references OSDOCS-11167 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
OSDOCS-11167

Link to docs preview:
LVMS CSI provider and CSI snapshot deployments are now configurable

QE review:

  • QE has approved this change.

SME review:

  • SME has approved this change.

Additional information:
related to PR #80823

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 23, 2024

@aravipra: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aravipra
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 23, 2024
@ShaunaDiaz ShaunaDiaz removed the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 23, 2024
ShaunaDiaz
ShaunaDiaz reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ShaunaDiaz ShaunaDiaz merged commit 361546d into openshift:enterprise-4.17 Sep 23, 2024
2 checks passed
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

+2 more reviewers

@cbippley cbippley cbippley left review comments

@mffiedler mffiedler mffiedler approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mffiedler mffiedler

@copejon copejon

@radeore radeore

@ShaunaDiaz ShaunaDiaz

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.17 GA
Development

Successfully merging this pull request may close these issues.
9 participants
@aravipra @openshift-ci-robot @ocpdocs-previewbot @radeore @copejon @cbippley @dhensel-rh @mffiedler @ShaunaDiaz