Skip to content

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Nov 13, 2024

Attempt to optimize and document ostree and bootc blueprint hierarchy.

CentOS image fetch will be removed as a follow-up in USHIFT-4868.
Bootc build times may be further optimized as a follow-up in USHIFT-4881 and USHIFT-4720

OSTree Summary
I could not make the overall build times faster. Layer 1 is the heaviest (~30m), but it's cached. Pre-submits and periodics take up to 10 and 15 minutes respectively.
I hope the "optimized" hierarchy is clearer and it is extensible if we add another OS version for instance.

Bootc Summary
Created a separate image-blueprints-bootc directory to be consistent with other bootc-specific sources.
The new hierarchy only results in a couple of minutes of time saving for builds, which are not significant. The main benefit atm is like for ostree - clear and extensible hierarchy.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2024

@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024

@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Attempt to optimize and document ostree and bootc blueprints. Note that CentOS image fetch will be removed as a follow-up in USHIFT-4868.

OSTree Summary
I could not make the overall build times faster. Layer 1 is the heaviest (~30m), but it's cached. Pre-submits and periodics take up to 10 and 15 minutes respectively.

Bootc Summary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024

@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Attempt to optimize and document ostree and bootc blueprint hierarchy.

CentOS image fetch will be removed as a follow-up in USHIFT-4868.

OSTree Summary
I could not make the overall build times faster. Layer 1 is the heaviest (~30m), but it's cached. Pre-submits and periodics take up to 10 and 15 minutes respectively.

Bootc Summary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024

@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Attempt to optimize and document ostree and bootc blueprint hierarchy.

CentOS image fetch will be removed as a follow-up in USHIFT-4868.

OSTree Summary
I could not make the overall build times faster. Layer 1 is the heaviest (~30m), but it's cached. Pre-submits and periodics take up to 10 and 15 minutes respectively.
I hope the "optimized" hierarchy is clearer and it is extensible if we add another OS version for instance.

Bootc Summary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024

@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Attempt to optimize and document ostree and bootc blueprint hierarchy.

CentOS image fetch will be removed as a follow-up in USHIFT-4868.
Bootc build times may be further optimized as a follow-up in USHIFT-4881

OSTree Summary
I could not make the overall build times faster. Layer 1 is the heaviest (~30m), but it's cached. Pre-submits and periodics take up to 10 and 15 minutes respectively.
I hope the "optimized" hierarchy is clearer and it is extensible if we add another OS version for instance.

Bootc Summary
Created a separate image-blueprints-bootc directory to be consistent with other bootc-specific sources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2024

@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Attempt to optimize and document ostree and bootc blueprint hierarchy.

CentOS image fetch will be removed as a follow-up in USHIFT-4868.
Bootc build times may be further optimized as a follow-up in USHIFT-4881 and USHIFT-4720

OSTree Summary
I could not make the overall build times faster. Layer 1 is the heaviest (~30m), but it's cached. Pre-submits and periodics take up to 10 and 15 minutes respectively.
I hope the "optimized" hierarchy is clearer and it is extensible if we add another OS version for instance.

Bootc Summary
Created a separate image-blueprints-bootc directory to be consistent with other bootc-specific sources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2024

@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Attempt to optimize and document ostree and bootc blueprint hierarchy.

CentOS image fetch will be removed as a follow-up in USHIFT-4868.
Bootc build times may be further optimized as a follow-up in USHIFT-4881 and USHIFT-4720

OSTree Summary
I could not make the overall build times faster. Layer 1 is the heaviest (~30m), but it's cached. Pre-submits and periodics take up to 10 and 15 minutes respectively.
I hope the "optimized" hierarchy is clearer and it is extensible if we add another OS version for instance.

Bootc Summary
Created a separate image-blueprints-bootc directory to be consistent with other bootc-specific sources.
The new hierarchy only results in a couple of minutes of time saving for builds, which are not significant. The main benefit atm is like for ostree - clear and extensible hierarchy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash marked this pull request as ready for review November 20, 2024 06:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2024
@openshift-ci openshift-ci bot requested review from agullon and dhensel-rh November 20, 2024 06:51
Copy link
Member

@pmtk pmtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that following is duplicated:

  • test/image-blueprints/layer2-presubmit/group1/rhel94-source-with-optionals.toml
  • test/image-blueprints/layer3-periodic/group1/rhel94-source-with-optionals.toml

Why do we need

  • test/image-blueprints-bootc/layer1-base/group1/rhel94-bootc-base.containerfile
  • test/image-blueprints-bootc/layer1-base/group2/rhel94-bootc.image-bootc

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc

@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 21, 2024

I noticed that following is duplicated:

  • test/image-blueprints/layer2-presubmit/group1/rhel94-source-with-optionals.toml
  • test/image-blueprints/layer3-periodic/group1/rhel94-source-with-optionals.toml

I removed the duplication, leaving the file in pre-submits

Why do we need

  • test/image-blueprints-bootc/layer1-base/group1/rhel94-bootc-base.containerfile
  • test/image-blueprints-bootc/layer1-base/group2/rhel94-bootc.image-bootc

The containerfile build a bootc layer, while .image-bootc is used to run bib for creating an ISO from that layer. Both are required.

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@ggiguash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 8116dc6 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk
Copy link
Member

pmtk commented Nov 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8af8fd0 into openshift:main Nov 21, 2024
14 of 15 checks passed
@ggiguash ggiguash deleted the blueprint_reorg branch November 21, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants