-
Notifications
You must be signed in to change notification settings - Fork 216
USHIFT-4742: Bootc and ostree blueprint structure reorganization #4173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ggiguash: This pull request references USHIFT-4742 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that following is duplicated:
- test/image-blueprints/layer2-presubmit/group1/rhel94-source-with-optionals.toml
- test/image-blueprints/layer3-periodic/group1/rhel94-source-with-optionals.toml
Why do we need
- test/image-blueprints-bootc/layer1-base/group1/rhel94-bootc-base.containerfile
- test/image-blueprints-bootc/layer1-base/group2/rhel94-bootc.image-bootc
/test e2e-aws-tests-bootc |
I removed the duplication, leaving the file in pre-submits
The containerfile build a bootc layer, while |
@ggiguash: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
8af8fd0
into
openshift:main
Attempt to optimize and document ostree and bootc blueprint hierarchy.
OSTree Summary
I could not make the overall build times faster. Layer 1 is the heaviest (~30m), but it's cached. Pre-submits and periodics take up to 10 and 15 minutes respectively.
I hope the "optimized" hierarchy is clearer and it is extensible if we add another OS version for instance.
Bootc Summary
Created a separate
image-blueprints-bootc
directory to be consistent with other bootc-specific sources.The new hierarchy only results in a couple of minutes of time saving for builds, which are not significant. The main benefit atm is like for ostree - clear and extensible hierarchy.