-
Notifications
You must be signed in to change notification settings - Fork 216
USHIFT-4742: Bootc and ostree blueprint structure reorganization #4173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fc19995
Merge branch 'bootc_offline_test' into blueprint_reorg
ggiguash c8aaa7b
Reorganize the bootc layer
ggiguash 19fc66f
Move bootc blueprints to their own directory
ggiguash da68f66
Merge branch 'main' into blueprint_reorg
ggiguash 2d5dce6
Remove layer4-ext which is no longer used by QE
ggiguash 1d0a506
Add ostree README document
ggiguash 37b66e8
Add estimated build times for bootc
ggiguash a27d609
Remove the rhel94-source-with-optionals blueprint duplication
ggiguash 8116dc6
Add container-encapsulate clarification to the bootc readme file
ggiguash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
The following guiding principles should be used when adding more artifacts to | ||
each layer or group under `test/image-blueprints-bootc` directory. | ||
|
||
> Important: Keep balanced build times within each group and maximize caching | ||
> of artifacts independent of the current source code. | ||
|
||
## Bootc Base Layer | ||
|
||
Artifacts built in this layer are cached. | ||
|
||
|Group |Build Time|Description| | ||
|------|----------|-----------| | ||
|group1| Short | Basic prerequisites | ||
|group2| Long | Artifacts independent of current sources | ||
|
||
> Note: Total build times are up to 15 minutes. | ||
|
||
## Bootc Source Layer | ||
|
||
Artifacts built in this layer cannot be cached as they depend on the current sources. | ||
|
||
|Group |Build Time|Description| | ||
|------|----------|-----------| | ||
|group1| Average | Current source prerequisites (RHEL and CentOS) | ||
|group2| Average | Current source artifacts on RHEL | ||
|group3| Average | Current source artifacts on CentOS (with 1 exception) | ||
|
||
> Note: | ||
> * Total build times are up to 15 minutes. | ||
> * The `rhel94-bootc-source-isolated.image-bootc` file is an exception in | ||
> `group3` as it uses RHEL. This is done not to create a group with a single | ||
> file. |
File renamed without changes.
File renamed without changes.
File renamed without changes.
31 changes: 31 additions & 0 deletions
31
test/image-blueprints-bootc/layer1-base/group2/rhel94-bootc-crel-optionals.containerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
FROM localhost/rhel94-test-agent:latest | ||
|
||
# Copy repository configuration | ||
COPY ./bootc-images/microshift-fast-datapath-rhel9.repo ./bootc-images/microshift-crel.repo ./bootc-images/microshift-rhocp-y.repo \ | ||
/etc/yum.repos.d/ | ||
|
||
# Print repository configuration contents. | ||
# Install MicroShift with optional components and cleanup. | ||
RUN dnf repoinfo --enabled && \ | ||
dnf install -y firewalld \ | ||
"microshift-{{ .Env.CURRENT_RELEASE_VERSION }}" "microshift-release-info-{{ .Env.CURRENT_RELEASE_VERSION }}" \ | ||
"microshift-olm-{{ .Env.CURRENT_RELEASE_VERSION }}" "microshift-multus-{{ .Env.CURRENT_RELEASE_VERSION }}" && \ | ||
systemctl enable microshift && \ | ||
rm -vf /etc/yum.repos.d/microshift-*.repo && \ | ||
dnf clean all | ||
|
||
# Extend Greenboot wait timeout to 10m for MicroShift to be ready. | ||
# Greenboot configuration must come after RPM install to avoid | ||
# /etc/greenboot/greenboot.conf overwrite by the package update. | ||
RUN printf "\nMICROSHIFT_WAIT_TIMEOUT_SEC=600\n" >> /etc/greenboot/greenboot.conf | ||
|
||
# Configure firewall | ||
RUN firewall-offline-cmd --zone=public --add-port=22/tcp && \ | ||
firewall-offline-cmd --zone=trusted --add-source=10.42.0.0/16 && \ | ||
firewall-offline-cmd --zone=trusted --add-source=169.254.169.1 && \ | ||
firewall-offline-cmd --zone=public --add-port=80/tcp && \ | ||
firewall-offline-cmd --zone=public --add-port=443/tcp && \ | ||
firewall-offline-cmd --zone=public --add-port=5353/udp && \ | ||
firewall-offline-cmd --zone=public --add-port=6443/tcp && \ | ||
firewall-offline-cmd --zone=public --add-port=30000-32767/tcp && \ | ||
firewall-offline-cmd --zone=public --add-port=30000-32767/udp |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
The following guiding principles should be used when adding more artifacts to | ||
each layer or group under `test/image-blueprints` directory. | ||
|
||
> Important: Keep balanced build times within each group and maximize caching | ||
> of artifacts independent of the current source code. | ||
|
||
## OSTree Base Layer | ||
|
||
Artifacts built in this layer are cached. | ||
|
||
Groups 1-to-3 enforce an ordered build chain, necessary to satisfy a mandatory | ||
layer dependency of `rhel94 os-only -> rhel94 y-2 -> rhel94 y-1`, which is needed | ||
for testing upgrades. | ||
|
||
|Group |Build Time|Description| | ||
|------|----------|-----------| | ||
|group1| Short | RHEL 9.4 OS-only base layer | ||
|group2| Short | RHEL 9.4 layer with MicroShift `y-2` packages | ||
|group3| Short | RHEL 9.4 layer with MicroShift `y-1` packages | ||
|group4| Average | Other artifacts independent of current sources | ||
|
||
> Note: Total build times are up to 30 minutes. | ||
|
||
## OSTree Presubmit Layer | ||
|
||
Artifacts built in this layer cannot be cached as they depend on the current sources. | ||
The artifacts are used by pre-submit and periodic CI jobs. | ||
|
||
|Group |Build Time|Description| | ||
|------|----------|-----------| | ||
|group1| Average | Current source prerequisites used in pre-submits and periodics | ||
|
||
> Note: Total build times are up to 10 minutes. | ||
|
||
## OSTree Periodic Layer | ||
|
||
Artifacts built in this layer cannot be cached as they depend on the current sources. | ||
The artifacts are only used by periodic CI jobs. | ||
|
||
|Group |Build Time|Description| | ||
|------|----------|-----------| | ||
|group1| Average | Current source prerequisites used only in periodics | ||
|
||
> Note: Total build times are up to 15 minutes. |
File renamed without changes.
File renamed without changes.
1 change: 0 additions & 1 deletion
1
test/image-blueprints/layer4-ext/group1/rhel94_microshift-ext.image-installer
This file was deleted.
Oops, something went wrong.
67 changes: 0 additions & 67 deletions
67
test/image-blueprints/layer4-ext/group1/rhel94_microshift-ext.toml
This file was deleted.
Oops, something went wrong.
12 changes: 0 additions & 12 deletions
12
test/image-blueprints/layer5-bootc/group2/rhel94-bootc-crel-optionals.containerfile
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.