Skip to content

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jul 7, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2025
@openshift-ci-robot
Copy link

@ggiguash: This pull request references Jira Issue OCPBUGS-58269, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 7, 2025
@openshift-ci openshift-ci bot requested a review from jogeo July 7, 2025 06:03
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2025

/test ?

Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

@ggiguash: The following commands are available to trigger required jobs:

/test e2e-aws-ai-model-serving
/test e2e-aws-footprint-and-performance
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm
/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm
/test e2e-aws-tests-periodic
/test e2e-aws-tests-periodic-arm
/test images
/test ocp-full-conformance-rhel-eus
/test ocp-full-conformance-serial-rhel-eus
/test test-rpm
/test test-unit
/test verify

The following commands are available to trigger optional jobs:

/test security
/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests
pull-ci-openshift-microshift-main-e2e-aws-tests-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm
pull-ci-openshift-microshift-main-images
pull-ci-openshift-microshift-main-security
pull-ci-openshift-microshift-main-test-unit
pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2025

/test e2e-aws-tests

@ggiguash ggiguash force-pushed the submgr-fix-register branch from 198da32 to a3083f7 Compare July 7, 2025 06:30
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2025

/test e2e-aws-tests

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2025

Looking at the sos reports of the rpm-install scenario.

$ grep subscription-manager sos_commands/logs/journalctl_--no-pager*  | grep -c register
0

$ grep submgr_script sos_commands/logs/journalctl_--no-pager*
sos_commands/logs/journalctl_--no-pager:Jul 07 03:22:09 el96-src-rpm-install-ostree-host1 sudo[1593]:   redhat : PWD=/home/redhat ; USER=root ; COMMAND=/tmp/submgr_script.oTEUepUw.sh
sos_commands/logs/journalctl_--no-pager_--boot_-1:Jul 07 03:22:09 el96-src-rpm-install-ostree-host1 sudo[1593]:   redhat : PWD=/home/redhat ; USER=root ; COMMAND=/tmp/submgr_script.oTEUepUw.sh

It seems that the subscription command line arguments are no longer present in the system logs.

@ggiguash ggiguash marked this pull request as ready for review July 7, 2025 08:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2025
@openshift-ci openshift-ci bot requested review from eslutsky and vanhalenar July 7, 2025 08:36
@pmtk
Copy link
Member

pmtk commented Jul 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0d1d7d3 into openshift:main Jul 7, 2025
13 checks passed
@openshift-ci-robot
Copy link

@ggiguash: Jira Issue OCPBUGS-58269: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-58269 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2025

/cherry-pick release-4.19

@ggiguash ggiguash deleted the submgr-fix-register branch July 7, 2025 13:51
@openshift-cherrypick-robot

@ggiguash: #5152 failed to apply on top of branch "release-4.19":

Applying: Fix subscription-manager registation command not to use sudo directly
Using index info to reconstruct a base tree...
M	test/bin/subscription_manager_register.sh
Falling back to patching base and 3-way merge...
Auto-merging test/bin/subscription_manager_register.sh
CONFLICT (content): Merge conflict in test/bin/subscription_manager_register.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix subscription-manager registation command not to use sudo directly

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants