Skip to content

OCPBUGS-58269: Add subscription manager registration wrapper script #66755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

OCPBUGS-58269: Add subscription manager registration wrapper script #66755

merged 1 commit into from
Jul 7, 2025

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jul 6, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 6, 2025
@openshift-ci-robot
Copy link
Contributor

@ggiguash: This pull request references Jira Issue OCPBUGS-58269, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 6, 2025
@openshift-ci openshift-ci bot requested review from jogeo, eslutsky and pacevedom July 6, 2025 15:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2025
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 6, 2025

/pj-rehearse ?

@openshift-ci-robot
Copy link
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ggiguash: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-main-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.21-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.21-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.20-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.20-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.19-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.19-e2e-aws-ai-model-serving openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.18-e2e-aws-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.17-footprint-and-performance openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-e2e-aws-tests-cache openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-e2e-aws-tests-cache-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.21-e2e-aws-tests-cache openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.21-e2e-aws-tests-cache-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.20-e2e-aws-tests-cache openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.20-e2e-aws-tests-cache-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.19-e2e-aws-tests-cache openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.19-e2e-aws-tests-cache-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-cache-nightly openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-cache-nightly-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-cache openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.18-e2e-aws-tests-cache-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.17-microshift-metal-cache openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-release-4.17-microshift-metal-cache-arm openshift/microshift presubmit Registry content changed
pull-ci-openshift-microshift-main-e2e-aws-tests openshift/microshift presubmit Registry content changed

A total of 185 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@ggiguash: job(s): ? either don't exist or were not found to be affected, and cannot be rehearsed

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 6, 2025

/pj-rehearse pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

@openshift-ci-robot
Copy link
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2025

Looking at the contents of the sos_commands/logs sub-directory of this sos-report

$ grep subscription-manager journalctl_--no-pager* | grep -c register
0

$ grep submgr_script journalctl_--no-pager* 
journalctl_--no-pager:Jul 06 15:38:00 i-0748a45852ea115fc.us-west-2.compute.internal sudo[8729]: ec2-user : PWD=/home/ec2-user ; USER=root ; COMMAND=/tmp/submgr_script.us122vR9.sh
journalctl_--no-pager_--boot:Jul 06 15:38:00 i-0748a45852ea115fc.us-west-2.compute.internal sudo[8729]: ec2-user : PWD=/home/ec2-user ; USER=root ; COMMAND=/tmp/submgr_script.us122vR9.sh

It seems that the workaround functions appropriately by not running exposing the subscription-manager command line arguments in the system logs.

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 7, 2025
pacevedom
pacevedom approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 932a2ea into openshift:master Jul 7, 2025
11 checks passed
@openshift-ci-robot
Copy link
Contributor

@ggiguash: Jira Issue OCPBUGS-58269: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-58269 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 7, 2025
Merged
MrSanketkumar pushed a commit to MrSanketkumar/release that referenced this pull request Aug 1, 2025
@ggiguash @MrSanketkumar
Add subscription manager registration wrapper script (openshift#66755)
4e23a58
liweinan pushed a commit to liweinan/release that referenced this pull request Aug 5, 2025
@ggiguash @liweinan
Add subscription manager registration wrapper script (openshift#66755)
76deda9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@eslutsky eslutsky Awaiting requested review from eslutsky

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggiguash @openshift-ci-robot @pacevedom