Configuring cloud plugins without credentials causes invalid volumeMounts

[dymurray]

Describe the bug
If I set gcp, azure, and aws as default velero plugins, but don't configure their respective secrets, the Velero CR shows no errors but the velero deployment, restic daemonset, and registry deployment fail to startup.

[dymurray@galt oadp-operator]$ oc get pods
NAME                                                 READY     STATUS              RESTARTS   AGE
oadp-operator-7dc5cb884c-f5tvb                       1/1       Running             0          10m
oadp-velero-sample-1-aws-registry-68b6579874-j6mws   0/1       CrashLoopBackOff    6          5m57s
restic-4sg7h                                         0/1       ContainerCreating   0          7m26s
restic-cg8bq                                         0/1       ContainerCreating   0          7m26s
restic-skt2d                                         0/1       ContainerCreating   0          7m26s
velero-74f64fcd5c-mq2lk                              0/1       Init:0/5            0          7m26s

The errors:

  Warning  FailedMount  1m (x2 over 3m)   kubelet, ip-10-0-155-20.ec2.internal  Unable to attach or mount volumes: unmounted volumes=[cloud-credentials-gcp cloud-credentials-azure], unattached volumes=[scratch certs cloud-credentials-gcp cloud-credentials-azure cloud-credentials velero-token-wf2sn host-pods]: timed out waiting for the condition

To Reproduce
Set default Velero plugins:

- csi
- gcp
- azure

But only configure AWS credentials.

Expected behavior
I would expect the Velero CR to display an error that I've misconfigured the CR.

Version of operator being used

• 0.3.0

[dymurray]

To resolve this... we want to add to the ValidateBackupStorageLocation reconciler logic that will check if a specific cloud provider plugin is specified, that the associated expected secret exists before trying to mount it in the container.

i.e. if I specify:

defaultVeleroPlugins:
- aws
- gcp

Then we must verify cloud-credentials and cloud-credentials-gcp secrets exist.