Skip to content

Fixing volume mount issue #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 25, 2021
Merged

Fixing volume mount issue #369

merged 11 commits into from
Oct 25, 2021

Conversation

savitharaghunathan
Copy link
Member

@savitharaghunathan savitharaghunathan commented Oct 5, 2021 •
edited
Loading

Fixes issue #331

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 5, 2021
@savitharaghunathan savitharaghunathan changed the title WIP: Fixing volume mount issue Fixing volume mount issue Oct 6, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2021
@savitharaghunathan
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2021
@savitharaghunathan
Copy link
Member Author

/retest-required

@shubham-pampattiwar
Copy link
Member

/test operator-e2e

@savitharaghunathan
Fixing volume mount issue
4c14004 
Adding logic to ignore openshift & csi default plugins
@savitharaghunathan
Copy link
Member Author

/test operator-e2e

@eemcmullan eemcmullan linked an issue Oct 12, 2021 that may be closed by this pull request
Configuring cloud plugins without credentials causes invalid volumeMounts #331
Closed
shubham-pampattiwar
shubham-pampattiwar requested changes Oct 18, 2021
View reviewed changes
dymurray
dymurray reviewed Oct 19, 2021
View reviewed changes
shubham-pampattiwar
shubham-pampattiwar reviewed Oct 19, 2021
View reviewed changes
dymurray
dymurray reviewed Oct 20, 2021
View reviewed changes
@codecov-commenter
Copy link

Codecov Report

Merging #369 (0cc5c0b) into master (bdbdc9b) will increase coverage by 0.93%.
The diff coverage is 95.65%.

❗ Current head 0cc5c0b differs from pull request most recent head 39a1984. Consider uploading reports for the commit 39a1984 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   39.98%   40.92%   +0.93%     
==========================================
  Files           9        9              
  Lines        1833     1835       +2     
==========================================
+ Hits          733      751      +18     
+ Misses       1053     1037      -16     
  Partials       47       47
Impacted Files Coverage Δ
controllers/vsl.go 52.75% <ø> (ø)
pkg/credentials/credentials.go 29.21% <0.00%> (ø)
controllers/bsl.go 62.56% <100.00%> (+0.21%) ⬆️
controllers/registry.go 40.77% <100.00%> (+2.46%) ⬆️
controllers/restic.go 57.21% <100.00%> (+0.20%) ⬆️
controllers/velero.go 36.66% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbdc9b...39a1984. Read the comment docs.

dymurray
dymurray approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dymurray
dymurray reviewed Oct 21, 2021
View reviewed changes
@shubham-pampattiwar shubham-pampattiwar merged commit 53069f9 into openshift:master Oct 25, 2021
@savitharaghunathan savitharaghunathan deleted the issue331 branch October 25, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@JaydipGabani JaydipGabani Awaiting requested review from JaydipGabani

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuring cloud plugins without credentials causes invalid volumeMounts
4 participants
@savitharaghunathan @shubham-pampattiwar @codecov-commenter @dymurray