Bug: AWS plugin config: BSL Region not required when `s3ForcePathStyle` is `false`

[kaovilai]

Contact Details

No response

Describe bug

When AWS plugin has s3ForcePathStyle and s3Url defined, a region does not need to be defined inside BSL.

What happened?

This velero CR should not have error status

apiVersion: oadp.openshift.io/v1alpha1
kind: Velero
metadata:
  name: example-velero
  namespace: openshift-adp
spec:
  backupStorageLocations:
    - backupSyncPeriod: 2m0s
      config:
        profile: default
        s3ForcePathStyle: 'true'
        s3Url: 'http://s3.openshift-storage.svc/'
      credential:
        key: cloud
        name: cloud-credentials
      default: true
      objectStorage:
        bucket: migstorage
        prefix: velero
      provider: aws
  defaultVeleroPlugins:
    - openshift
    - aws
    - csi
  enableRestic: true
  veleroFeatureFlags:
    - EnableCSI
  volumeSnapshotLocations:
    - config:
        profile: default
        region: us-east-1
      provider: aws
status:
  conditions:
    - lastTransitionTime: '2021-10-29T18:03:27Z'
      message: >-
        prefix and region for AWS backupstoragelocation object storage cannot be
        empty. It is required for backing up images
      reason: Error
      status: 'False'
      type: Reconciled

OADP Version

0.4.x (Beta)

OpenShift Version

4.8

Velero pod logs

No response

Restic pod logs

No response

Operator pod logs

No response

New issue

• This issue is new

[kaovilai]

For context, this CR is for oadp-lab which always use local object storage but in one of the exercises uses EBS CSI snapshot. (it may not even need the VSL defined).

[kaovilai]

Solution:

1. Remove BSL region requirement IF s3url is not defined.
2. If s3url is not defined, query region (without requirring user input) for. registry if backupImages=true

Implement like upstream using GetBucketRegion function

[kaovilai]

Title updated based on info from
vmware-tanzu/velero#4305

[kaovilai]

Waiting on behavior confirmation when

• Region is not optional if s3ForcePathStyle is true vmware-tanzu/velero-plugin-for-aws#91
  is closed or merged