AWS plugin config: BSL Region not required when s3ForcePathStyle is false and BackupImages is false #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
kaovilai
force-pushed
the
noBslRegion
branch
from
865bd92 to
086b99b
Compare
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
+ Coverage 39.02% 39.10% +0.07%
==========================================
Files 12 12
Lines 2378 2381 +3
==========================================
+ Hits 928 931 +3
+ Misses 1371 1370 -1
- Partials 79 80 +1
Continue to review full report at Codecov.
|
kaovilai
force-pushed
the
noBslRegion
branch
from
086b99b to
e39b5a0
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
kaovilai
force-pushed
the
noBslRegion
branch
from
e39b5a0 to
34759dd
Compare
kaovilai
force-pushed
the
noBslRegion
branch
from
34759dd to
8cdb0cd
Compare
kaovilai
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
kaovilai
force-pushed
the
noBslRegion
branch
from
48e5bc9 to
d940d1e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
1 task
kaovilai
force-pushed
the
noBslRegion
branch
from
08de983 to
5994a16
Compare
dymurray
reviewed
Dec 20, 2021
kaovilai
force-pushed
the
noBslRegion
branch
from
d443511 to
23fb6ab
Compare
|
Looks like registry currently use region. If backupImages is enabled, region is still required. |
kaovilai
force-pushed
the
noBslRegion
branch
from
fa26e81 to
d407954
Compare
kaovilai
force-pushed
the
noBslRegion
branch
from
d407954 to
d14c33b
Compare
kaovilai
changed the title
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dymurray
approved these changes
Dec 21, 2021
kaovilai
added a commit
to kaovilai/oadp-operator
that referenced
this pull request
Dec 22, 2021
* api v1 upgrade CR typo (openshift#501) * Removing kube-rbac-proxy from the containers needed (openshift#504) * fix indentation (openshift#505) * turn OCP versions from int to string (openshift#502) * Ensure velero is deleted (openshift#510) * Timeout for must-gather failed backups (openshift#497) * Adding known limitations to must-gather * Adding implementation details for timeout * remove VSPHERE env configs for csv (openshift#512) * update troubleshooting doc (openshift#509) * Adding support for service principal credential for Azure plugin (openshift#507) * Adding validation for azure creds * Adding account key check * Adding checks to validate SP if storage key is not present * Adding unit test#1 * Adding a test case for service principal * Adding review comments * Remove: logging sensitive info * make deploy velero namespace fix (openshift#506) * make deploy velero namespace fix * add changes for undeploy * add deploy-tmp-cleanup * fix aws registry env vars (openshift#515) * Azure SP docs (openshift#514) * Adding Azure SP related doc * Fixing title * Fixing nit * Registry should not be deployed when Azure SP is used (openshift#518) * Registry should not be deployed when Azure SP is used * Fixing unit tests * Adding review comments * Fixing typos * Adding registry label to BSL * Updating azure credentials documentation (openshift#519) * AWS plugin config: BSL Region not required when s3ForcePathStyle is false and BackupImages is false (openshift#517) * OADP-153, Close openshift#424 * Nil restic Config should delete previous restic daemonset * only check restic config if it is not nil * installCase wantError implement * Make err more verbose * commit metav1 * Changes for BackupImages considerations * fake client fix * removed vsphere from source manager config (openshift#520) * Update README.md * badge relocate (openshift#521) Co-authored-by: Tiger Kaovilai <[email protected]> Co-authored-by: Shawn Hurley <[email protected]> Co-authored-by: Emily McMullan <[email protected]> Co-authored-by: Savitha Raghunathan <[email protected]> Co-authored-by: Wesley Hayutin <[email protected]> Co-authored-by: Dylan Murray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #424
Closes OADP-153
nil