Skip to content

CSI Backup-restore E2E test #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 12, 2021
Merged

CSI Backup-restore E2E test #430

merged 14 commits into from
Nov 12, 2021

Conversation

hhpatel14
Copy link
Contributor

@hhpatel14 hhpatel14 commented Nov 2, 2021 •
edited by kaovilai
Loading

Closes #192

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 2, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021 •
edited
Loading

Codecov Report

Merging #430 (28e4cce) into master (7763e55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   41.48%   41.48%           
=======================================
  Files           9        9           
  Lines        1849     1849           
=======================================
  Hits          767      767           
  Misses       1033     1033           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7763e55...28e4cce. Read the comment docs.

@hhpatel14
Copy link
Contributor Author

/retest

@hhpatel14 hhpatel14 changed the title [WIP]CSI Backup-restore E2E test CSI Backup-restore E2E test Nov 3, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2021
dymurray
dymurray approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part this LGTM! just a couple nits to update and we can merge

@hhpatel14
Copy link
Contributor Author

/retest

@dymurray
Copy link
Member

dymurray commented Nov 4, 2021

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

New changes are detected. LGTM label has been removed.

@hhpatel14
Copy link
Contributor Author

/retest

1 similar comment
@hhpatel14
Copy link
Contributor Author

/retest

@hhpatel14
Copy link
Contributor Author

/retest-required

@hhpatel14
Copy link
Contributor Author

/skip

@hongkailiu
Copy link
Member

/test all

@hhpatel14
Copy link
Contributor Author

/retest

@hhpatel14
Copy link
Contributor Author

/retest

@hhpatel14
Copy link
Contributor Author

/retest

@hhpatel14 hhpatel14 merged commit ed16f9e into openshift:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray approved these changes

@alaypatel07 alaypatel07 Awaiting requested review from alaypatel07

@rayfordj rayfordj Awaiting requested review from rayfordj

Assignees

@dymurray dymurray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement CSI snapshot E2E test case for backup/restore
5 participants
@hhpatel14 @codecov-commenter @dymurray @hongkailiu @savitharaghunathan