-
Notifications
You must be signed in to change notification settings - Fork 82
master: Makefile Automate operator-sdk install, preserve nullables. #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tiger Kaovilai <[email protected]>
Codecov ReportBase: 33.53% // Head: 33.53% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 33.53% 33.53%
=======================================
Files 17 17
Lines 3152 3152
=======================================
Hits 1057 1057
Misses 2003 2003
Partials 92 92 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/retest |
1 similar comment
/retest |
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the make test
crd formatting issue for me.
/cherry-pick oadp-1.1 |
@kaovilai: #846 failed to apply on top of branch "oadp-1.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…penshift#846) * Makefile automate operator-sdk installation * pin yq to 4.28.1 for go 1.17 * Preserve DPA nullables for `make test` Signed-off-by: Tiger Kaovilai <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]>
…penshift#846) * Makefile automate operator-sdk installation * pin yq to 4.28.1 for go 1.17 * Preserve DPA nullables for `make test` Signed-off-by: Tiger Kaovilai <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]>
* master: Makefile Automate operator-sdk install, preserve nullables. (#846) * Makefile automate operator-sdk installation * pin yq to 4.28.1 for go 1.17 * Preserve DPA nullables for `make test` Signed-off-by: Tiger Kaovilai <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]> * ran `make bundle` Signed-off-by: Tiger Kaovilai <[email protected]>
Might fix
make deploy-olm
image override workarounds by forcing use of a GitHub release binary which hopefully uses tagged version of opm instead of latest by default.