Skip to content

oadp-1.1: yq format when for make test. pin gomega to v1.22 #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2022
Merged

oadp-1.1: yq format when for make test. pin gomega to v1.22 #859

merged 2 commits into from
Nov 21, 2022

Conversation

kaovilai
Copy link
Member

Cherrypick #846 to oadp-1.1

@openshift-ci openshift-ci bot requested review from sseago and weshayutin October 21, 2022 16:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022 •
edited
Loading

Codecov Report

Base: 32.65% // Head: 32.65% // No change to project coverage 👍

Coverage data is based on head (2eee73d) compared to base (165e436).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##           oadp-1.1     #859   +/-   ##
=========================================
  Coverage     32.65%   32.65%           
=========================================
  Files            17       17           
  Lines          3237     3237           
=========================================
  Hits           1057     1057           
  Misses         2088     2088           
  Partials         92       92

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaovilai
Copy link
Member Author

kaovilai commented Nov 2, 2022

/retest

kaovilai
kaovilai commented Nov 2, 2022
View reviewed changes
build/custom-ci-Dockerfile Outdated
@@ -1,8 +1,9 @@
FROM openshift/origin-release:golang-1.16
FROM openshift/origin-release:golang-1.17
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this image tag golang-1.17 doesn't actually exists at least in docker hub.

Will check and maybe remove this file if it's not used anywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will delete in a follow up later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks to be a leftover from ansible days

@kaovilai
Copy link
Member Author

kaovilai commented Nov 3, 2022

/retest

1 similar comment
@kaovilai
Copy link
Member Author

kaovilai commented Nov 3, 2022

/retest

@kaovilai kaovilai changed the title oadp-1.1: make test yq formatting. oadp-1.1: make test yq formatting. pin gomega to v1.22 Nov 3, 2022
@kaovilai kaovilai changed the title oadp-1.1: make test yq formatting. pin gomega to v1.22 oadp-1.1: yq format when for make test. pin gomega to v1.22 Nov 3, 2022
@weshayutin
Copy link
Contributor

Do we want this change on OADP-1.1.1 ?

@kaovilai
Copy link
Member Author

Let's punt for 1.1.2

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2022
@kaovilai
master: Makefile Automate operator-sdk install, preserve nullables. (o…
a7bc303 
…penshift#846)

* Makefile automate operator-sdk installation

* pin yq to 4.28.1 for go 1.17

* Preserve DPA nullables for `make test`

Signed-off-by: Tiger Kaovilai <[email protected]>

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai
ran make bundle
a8325fa
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dymurray dymurray merged commit 772fb8b into openshift:oadp-1.1 Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sseago sseago sseago approved these changes

@dymurray dymurray dymurray approved these changes

@weshayutin weshayutin Awaiting requested review from weshayutin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaovilai @codecov-commenter @weshayutin @sseago @dymurray @openshift-merge-robot