Skip to content

Conversation

isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Apr 14, 2025

Closes: OCPBUGS-54951

This reintroduces the work originally added in #29596 and then reverted in #29682.

Work Included

  • All work from the original PR MCO-1520: Add MachineConfigNode e2e tests #29596
  • Test updates, included in commit 6f7469e, to improve overall stability
    • Update to the Validate MCN properties test to divide default and custom MCP cases into separate tests. This will help keep the tests shorter and more appropriately scoped.
    • Update to the Validate MCN condition status transitions test to do a rebootless update instead of the previous reboot-required update.

Relevant information on revert

Notes

  • The tests for MCO-1595 & MCO-1596 will both run in the default serial suite since they can impact other tests through pool creation and updates.
  • The tests for MCO-1597 & MCO-1598 are both tagged Slow, as they often take longer than 5 minutes to run. To have these tests run automatically, we will need to create a suite at a later time (Slack ref), but the tests can still be run locally.
  • The tests for MCO-1599 will all run in the default parallel suite since they are not computationally expensive, simple, and should have no affects on other tests.

MCO-1595: Validate MCN properties

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Note that the following test is skipped for Single Node Openshift since it tests with the creation of a custom MCP.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties for nodes in custom MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

MCO-1596: Validate MCN condition status transitions

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should properly transition through MCN conditions on rebootless node update [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

(Does not run in a default test suite) MCO-1597: Validate MCN condition status on node degrade

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly report MCN conditions on node degrade [apigroup:machineconfiguration.openshift.io]"

(Does not run in a default test suite) MCO-1598: Validate MCN on node creation and deletion

Note that this test is skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly create and remove MCN on node creation and deletion [apigroup:machineconfiguration.openshift.io]"

MCO-1599: Validate MCN object can only be accessible from its associated MCD

Note that these tests are skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates from a MCD that is not the associated one [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly update the MCN from the associated MCD [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025

@isabella-janssen: This pull request references MCO-1520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This reintroduces the work originally added in #29596 and then reverted in #29682.

Work Included

Notes

  • The tests for MCO-1595 & MCO-1596 will both run in the default serial suite since they can impact other tests through pool creation and updates.
  • The tests for MCO-1597 & MCO-1598 are both tagged Slow, as they often take longer than 5 minutes to run. To have these tests run automatically, we will need to create a suite at a later time (Slack ref), but the tests can still be run locally.
  • The tests for MCO-1599 will all run in the default parallel suite since they are not computationally expensive, simple, and should have no affects on other tests.

MCO-1595: Validate MCN properties

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

MCO-1596: Validate MCN condition status transitions

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should properly transition through MCN conditions on rebootless node update [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

MCO-1597: Validate MCN condition status on node degrade

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly report MCN conditions on node degrade [apigroup:machineconfiguration.openshift.io]"

MCO-1598: Validate MCN on node creation and deletion

Note that this test is skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly create and remove MCN on node creation and deletion [apigroup:machineconfiguration.openshift.io]"

MCO-1599: Validate MCN object can only be accessible from its associated MCD

Note that these tests are skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates from a MCD that is not the associated one [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen force-pushed the mco-1520-retry branch 4 times, most recently from 5d42594 to 9606854 Compare April 14, 2025 21:28
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025

@isabella-janssen: This pull request references MCO-1520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This reintroduces the work originally added in #29596 and then reverted in #29682.

Work Included

  • All work from the original PR MCO-1520: Add MachineConfigNode e2e tests #29596
  • Update to the Validate MCN properties test to divide default and custom MCP cases into separate tests. This will help keep the tests shorter and more appropriately scoped.
  • Update to the Validate MCN condition status transitions test to do a rebootless update instead of the previous reboot-required update.

Notes

  • The tests for MCO-1595 & MCO-1596 will both run in the default serial suite since they can impact other tests through pool creation and updates.
  • The tests for MCO-1597 & MCO-1598 are both tagged Slow, as they often take longer than 5 minutes to run. To have these tests run automatically, we will need to create a suite at a later time (Slack ref), but the tests can still be run locally.
  • The tests for MCO-1599 will all run in the default parallel suite since they are not computationally expensive, simple, and should have no affects on other tests.

MCO-1595: Validate MCN properties

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

Note that the following test is skipped for Single Node Openshift since it tests the creation of a custom MCP.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties for nodes in custom MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

MCO-1596: Validate MCN condition status transitions

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should properly transition through MCN conditions on rebootless node update [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

MCO-1597: Validate MCN condition status on node degrade

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly report MCN conditions on node degrade [apigroup:machineconfiguration.openshift.io]"

MCO-1598: Validate MCN on node creation and deletion

Note that this test is skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly create and remove MCN on node creation and deletion [apigroup:machineconfiguration.openshift.io]"

MCO-1599: Validate MCN object can only be accessible from its associated MCD

Note that these tests are skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates from a MCD that is not the associated one [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@isabella-janssen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dc508600-1978-11f0-91de-f3cbdeabc429-0

@openshift-ci-robot
Copy link

@isabella-janssen: This pull request references MCO-1520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This reintroduces the work originally added in #29596 and then reverted in #29682.

Work Included

  • All work from the original PR MCO-1520: Add MachineConfigNode e2e tests #29596
  • Update to the Validate MCN properties test to divide default and custom MCP cases into separate tests. This will help keep the tests shorter and more appropriately scoped.
  • Update to the Validate MCN condition status transitions test to do a rebootless update instead of the previous reboot-required update.

Notes

  • The tests for MCO-1595 & MCO-1596 will both run in the default serial suite since they can impact other tests through pool creation and updates.
  • The tests for MCO-1597 & MCO-1598 are both tagged Slow, as they often take longer than 5 minutes to run. To have these tests run automatically, we will need to create a suite at a later time (Slack ref), but the tests can still be run locally.
  • The tests for MCO-1599 will all run in the default parallel suite since they are not computationally expensive, simple, and should have no affects on other tests.

MCO-1595: Validate MCN properties

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

Note that the following test is skipped for Single Node Openshift since it tests with the creation of a custom MCP.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties for nodes in custom MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

MCO-1596: Validate MCN condition status transitions

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should properly transition through MCN conditions on rebootless node update [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

MCO-1597: Validate MCN condition status on node degrade

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly report MCN conditions on node degrade [apigroup:machineconfiguration.openshift.io]"

MCO-1598: Validate MCN on node creation and deletion

Note that this test is skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly create and remove MCN on node creation and deletion [apigroup:machineconfiguration.openshift.io]"

MCO-1599: Validate MCN object can only be accessible from its associated MCD

Note that these tests are skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates from a MCD that is not the associated one [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@isabella-janssen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/30932e70-199c-11f0-98d5-22e070356ce4-0

@isabella-janssen
Copy link
Member Author

/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial

Copy link

openshift-trt bot commented Apr 15, 2025

Job Failure Risk Analysis for sha: 78933fb

Job Name Failure Risk
pull-ci-openshift-origin-main-okd-e2e-gcp IncompleteTests
Tests for this run (15) are below the historical average (23): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 78933fb

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial Medium - "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties for nodes in custom MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial Medium - "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should properly transition through MCN conditions on rebootless node update [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-bgp-techpreview Medium - "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 78933fb

  • "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties for nodes in custom MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should properly transition through MCN conditions on rebootless node update [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@isabella-janssen
Copy link
Member Author

/test e2e-aws-ovn-single-node-techpreview-serial

@isabella-janssen
Copy link
Member Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial 5

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a0e21e90-19f9-11f0-90eb-774611c6fe47-0

@isabella-janssen isabella-janssen force-pushed the mco-1520-retry branch 2 times, most recently from 3ab71e2 to e7cc360 Compare April 15, 2025 15:47
@isabella-janssen
Copy link
Member Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial 5

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d51872b0-1a15-11f0-856c-5bfad6e18833-0

@isabella-janssen
Copy link
Member Author

/test e2e-aws-ovn-single-node-techpreview-serial

@isabella-janssen
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 17, 2025
@openshift-ci-robot
Copy link

@isabella-janssen: This pull request references Jira Issue OCPBUGS-54951, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mike-nguyen April 17, 2025 15:18
@xueqzhan
Copy link
Contributor

/lgtm

The aggregated job runs all show only one set of node state change now.

Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, xueqzhan, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2025
@xueqzhan
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f5a8115 and 2 for PR HEAD 6f7469e in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f5a8115 and 2 for PR HEAD 6f7469e in total

@isabella-janssen
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11058f6 and 1 for PR HEAD 6f7469e in total

Copy link

openshift-trt bot commented Apr 18, 2025

Job Failure Risk Analysis for sha: 6f7469e

Job Name Failure Risk
pull-ci-openshift-origin-main-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback IncompleteTests
Tests for this run (10) are below the historical average (192): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
---
[bz-Etcd] clusteroperator/etcd should not change condition/Available
Potential external regression detected for High Risk Test analysis

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 6f7469e

  • "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 2, Pass: 2, Fail: 0, Flake: 2]

Copy link

openshift-trt bot commented Apr 18, 2025

Job Failure Risk Analysis for sha: 6f7469e

Job Name Failure Risk
pull-ci-openshift-origin-main-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback IncompleteTests
Tests for this run (10) are below the historical average (192): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
---
[bz-Etcd] clusteroperator/etcd should not change condition/Available
Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones IncompleteTests
Tests for this run (26) are below the historical average (2327): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips IncompleteTests
Tests for this run (24) are below the historical average (2736): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 6f7469e

  • "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 2, Pass: 2, Fail: 0, Flake: 2]

@isabella-janssen
Copy link
Member Author

/retest-required

Copy link

openshift-trt bot commented Apr 18, 2025

Job Failure Risk Analysis for sha: 6f7469e

Job Name Failure Risk
pull-ci-openshift-origin-main-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback IncompleteTests
Tests for this run (10) are below the historical average (188): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
---
[bz-Etcd] clusteroperator/etcd should not change condition/Available
Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones IncompleteTests
Tests for this run (104) are below the historical average (2273): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips IncompleteTests
Tests for this run (102) are below the historical average (2679): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial IncompleteTests
Tests for this run (102) are below the historical average (1512): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 6f7469e

  • "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 2, Pass: 2, Fail: 0, Flake: 2]

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11058f6 and 2 for PR HEAD 6f7469e in total

@isabella-janssen
Copy link
Member Author

/retest-required

1 similar comment
@isabella-janssen
Copy link
Member Author

/retest-required

@sdodson
Copy link
Member

sdodson commented Apr 18, 2025

/override ci/prow/e2e-aws-ovn-edge-zones ci/prow/e2e-aws-ovn-fips ci/prow/e2e-aws-ovn-serial

This change was merged in the past because it caused e2e-aws-ovn-techpreview-serial to fail, that's not a presubmit but several payload tests were run and at least a few of them passed, most of those that failed were due to the ongoing service degradation in CI. So overriding the remaining tests so that we get this in with enough time to gather data to make a decision on promoting next week.

Copy link
Contributor

openshift-ci bot commented Apr 18, 2025

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial

In response to this:

/override ci/prow/e2e-aws-ovn-edge-zones ci/prow/e2e-aws-ovn-fips ci/prow/e2e-aws-ovn-serial

This change was merged in the past because it caused e2e-aws-ovn-techpreview-serial to fail, that's not a presubmit but several payload tests were run and at least a few of them passed, most of those that failed were due to the ongoing service degradation in CI. So overriding the remaining tests so that we get this in with enough time to gather data to make a decision on promoting next week.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson sdodson merged commit dc67a3a into openshift:main Apr 18, 2025
28 of 55 checks passed
@openshift-ci-robot
Copy link

@isabella-janssen: Jira Issue OCPBUGS-54951: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54951 has been moved to the MODIFIED state.

In response to this:

Closes: OCPBUGS-54951

This reintroduces the work originally added in #29596 and then reverted in #29682.

Work Included

  • All work from the original PR MCO-1520: Add MachineConfigNode e2e tests #29596
  • Test updates, included in commit 6f7469e, to improve overall stability
    • Update to the Validate MCN properties test to divide default and custom MCP cases into separate tests. This will help keep the tests shorter and more appropriately scoped.
    • Update to the Validate MCN condition status transitions test to do a rebootless update instead of the previous reboot-required update.

Relevant information on revert

Notes

  • The tests for MCO-1595 & MCO-1596 will both run in the default serial suite since they can impact other tests through pool creation and updates.
  • The tests for MCO-1597 & MCO-1598 are both tagged Slow, as they often take longer than 5 minutes to run. To have these tests run automatically, we will need to create a suite at a later time (Slack ref), but the tests can still be run locally.
  • The tests for MCO-1599 will all run in the default parallel suite since they are not computationally expensive, simple, and should have no affects on other tests.

MCO-1595: Validate MCN properties

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Note that the following test is skipped for Single Node Openshift since it tests with the creation of a custom MCP.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties for nodes in custom MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

MCO-1596: Validate MCN condition status transitions

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should properly transition through MCN conditions on rebootless node update [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

(Does not run in a default test suite) MCO-1597: Validate MCN condition status on node degrade

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly report MCN conditions on node degrade [apigroup:machineconfiguration.openshift.io]"

(Does not run in a default test suite) MCO-1598: Validate MCN on node creation and deletion

Note that this test is skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly create and remove MCN on node creation and deletion [apigroup:machineconfiguration.openshift.io]"

MCO-1599: Validate MCN object can only be accessible from its associated MCD

Note that these tests are skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates from a MCD that is not the associated one [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen deleted the mco-1520-retry branch April 18, 2025 13:13
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202504181514.p0.gdc67a3a.assembly.stream.el9.
All builds following this will include this PR.

Copy link
Contributor

openshift-ci bot commented Apr 18, 2025

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-techpreview-serial 78933fb link false /test e2e-gcp-ovn-techpreview-serial
ci/prow/e2e-aws-ovn-single-node-techpreview-serial a68c4c5 link false /test e2e-aws-ovn-single-node-techpreview-serial
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview 6f7469e link false /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview
ci/prow/e2e-aws-ovn-cgroupsv2 6f7469e link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-disruptive 6f7469e link false /test e2e-aws-disruptive
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 6f7469e link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-aws-ovn-etcd-scaling 6f7469e link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-single-node 6f7469e link false /test e2e-aws-ovn-single-node
ci/prow/e2e-azure-ovn-etcd-scaling 6f7469e link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-techpreview 6f7469e link false /test e2e-metal-ipi-ovn-dualstack-bgp-techpreview
ci/prow/e2e-gcp-fips-serial 6f7469e link false /test e2e-gcp-fips-serial
ci/prow/e2e-aws-ovn-single-node-serial 6f7469e link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn 6f7469e link false /test e2e-aws-ovn
ci/prow/e2e-aws-csi 6f7469e link false /test e2e-aws-csi
ci/prow/e2e-aws-proxy 6f7469e link false /test e2e-aws-proxy
ci/prow/e2e-aws 6f7469e link false /test e2e-aws
ci/prow/e2e-gcp-ovn-etcd-scaling 6f7469e link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-upgrade 6f7469e link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 6f7469e link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-disruptive 6f7469e link false /test e2e-gcp-disruptive
ci/prow/e2e-aws-ovn-upgrade 6f7469e link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade 6f7469e link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 6f7469e link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-openstack-serial 6f7469e link false /test e2e-openstack-serial
ci/prow/e2e-agnostic-ovn-cmd 6f7469e link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-vsphere-ovn-etcd-scaling 6f7469e link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/okd-scos-e2e-aws-ovn 6f7469e link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-gcp 6f7469e link false /test okd-e2e-gcp
ci/prow/e2e-aws-ovn-serial 6f7469e link unknown /test e2e-aws-ovn-serial
ci/prow/e2e-gcp-ovn-upgrade 6f7469e link unknown /test e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-ovn 6f7469e link unknown /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-fips 6f7469e link unknown /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-microshift-serial 6f7469e link unknown /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-edge-zones 6f7469e link unknown /test e2e-aws-ovn-edge-zones
ci/prow/e2e-vsphere-ovn 6f7469e link unknown /test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-microshift 6f7469e link unknown /test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@isabella-janssen: Jira Issue OCPBUGS-54951 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Closes: OCPBUGS-54951

This reintroduces the work originally added in #29596 and then reverted in #29682.

Work Included

  • All work from the original PR MCO-1520: Add MachineConfigNode e2e tests #29596
  • Test updates, included in commit 6f7469e, to improve overall stability
    • Update to the Validate MCN properties test to divide default and custom MCP cases into separate tests. This will help keep the tests shorter and more appropriately scoped.
    • Update to the Validate MCN condition status transitions test to do a rebootless update instead of the previous reboot-required update.

Relevant information on revert

Notes

  • The tests for MCO-1595 & MCO-1596 will both run in the default serial suite since they can impact other tests through pool creation and updates.
  • The tests for MCO-1597 & MCO-1598 are both tagged Slow, as they often take longer than 5 minutes to run. To have these tests run automatically, we will need to create a suite at a later time (Slack ref), but the tests can still be run locally.
  • The tests for MCO-1599 will all run in the default parallel suite since they are not computationally expensive, simple, and should have no affects on other tests.

MCO-1595: Validate MCN properties

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should have MCN properties matching associated node properties for nodes in default MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Note that the following test is skipped for Single Node Openshift since it tests with the creation of a custom MCP.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should have MCN properties matching associated node properties for nodes in custom MCPs [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

MCO-1596: Validate MCN condition status transitions

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial]Should properly transition through MCN conditions on rebootless node update [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/serial]"

(Does not run in a default test suite) MCO-1597: Validate MCN condition status on node degrade

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly report MCN conditions on node degrade [apigroup:machineconfiguration.openshift.io]"

(Does not run in a default test suite) MCO-1598: Validate MCN on node creation and deletion

Note that this test is skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] [Serial][Slow]Should properly create and remove MCN on node creation and deletion [apigroup:machineconfiguration.openshift.io]"

MCO-1599: Validate MCN object can only be accessible from its associated MCD

Note that these tests are skipped for Single Node Openshift.

./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates by impersonation of the MCD SA [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly block MCN updates from a MCD that is not the associated one [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"
./openshift-tests run-test "[sig-mco][OCPFeatureGate:MachineConfigNodes] Should properly update the MCN from the associated MCD [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants