-
Notifications
You must be signed in to change notification settings - Fork 4.7k
OCPBUGS-54951: MCO-1520: Reintroduction of MachineConfigNode e2e tests #29683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@isabella-janssen: This pull request references MCO-1520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5d42594
to
9606854
Compare
@isabella-janssen: This pull request references MCO-1520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b967f37
to
3f7c304
Compare
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
@isabella-janssen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dc508600-1978-11f0-91de-f3cbdeabc429-0 |
@isabella-janssen: This pull request references MCO-1520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2e6a91e
to
78933fb
Compare
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
@isabella-janssen: trigger 4 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/30932e70-199c-11f0-98d5-22e070356ce4-0 |
/test e2e-aws-ovn-single-node-techpreview-serial e2e-gcp-ovn-techpreview-serial |
Job Failure Risk Analysis for sha: 78933fb
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 78933fb
New tests seen in this PR at sha: 78933fb
|
/test e2e-aws-ovn-single-node-techpreview-serial |
/payload-aggregate periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial 5 |
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a0e21e90-19f9-11f0-90eb-774611c6fe47-0 |
3ab71e2
to
e7cc360
Compare
/payload-aggregate periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial 5 |
@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d51872b0-1a15-11f0-856c-5bfad6e18833-0 |
/test e2e-aws-ovn-single-node-techpreview-serial |
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial |
@isabella-janssen: This pull request references Jira Issue OCPBUGS-54951, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm The aggregated job runs all show only one set of node state change now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, xueqzhan, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest-required |
Job Failure Risk Analysis for sha: 6f7469e
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 6f7469e
|
Job Failure Risk Analysis for sha: 6f7469e
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 6f7469e
|
/retest-required |
Job Failure Risk Analysis for sha: 6f7469e
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 6f7469e
|
/retest-required |
1 similar comment
/retest-required |
/override ci/prow/e2e-aws-ovn-edge-zones ci/prow/e2e-aws-ovn-fips ci/prow/e2e-aws-ovn-serial This change was merged in the past because it caused e2e-aws-ovn-techpreview-serial to fail, that's not a presubmit but several payload tests were run and at least a few of them passed, most of those that failed were due to the ongoing service degradation in CI. So overriding the remaining tests so that we get this in with enough time to gather data to make a decision on promoting next week. |
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-ovn-edge-zones, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@isabella-janssen: Jira Issue OCPBUGS-54951: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-54951 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
@isabella-janssen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@isabella-janssen: Jira Issue OCPBUGS-54951 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Closes: OCPBUGS-54951
This reintroduces the work originally added in #29596 and then reverted in #29682.
Work Included
Validate MCN properties
test to divide default and custom MCP cases into separate tests. This will help keep the tests shorter and more appropriately scoped.Validate MCN condition status transitions
test to do a rebootless update instead of the previous reboot-required update.Relevant information on revert
Notes
Slow
, as they often take longer than 5 minutes to run. To have these tests run automatically, we will need to create a suite at a later time (Slack ref), but the tests can still be run locally.MCO-1595: Validate MCN properties
Note that the following test is skipped for Single Node Openshift since it tests with the creation of a custom MCP.
MCO-1596: Validate MCN condition status transitions
(Does not run in a default test suite) MCO-1597: Validate MCN condition status on node degrade
(Does not run in a default test suite) MCO-1598: Validate MCN on node creation and deletion
Note that this test is skipped for Single Node Openshift.
MCO-1599: Validate MCN object can only be accessible from its associated MCD
Note that these tests are skipped for Single Node Openshift.