Skip to content

OCPBUGS-54951: MCO-1520: Reintroduction of MachineConfigNode e2e tests #29683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025
Merged

OCPBUGS-54951: MCO-1520: Reintroduction of MachineConfigNode e2e tests #29683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
416a2f7
owners: update MCO team list
isabella-janssen Mar 10, 2025
3a6cbb6
mco-1520: implement origin tests for MachineConfigNode
isabella-janssen Apr 10, 2025
6f7469e
mco-1596: change node update to be rebootless & mco-1595: divide test…
isabella-janssen Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/extended/machine_config/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,18 @@ approvers:
- dkhater-redhat
- yuqi-zhang
- cheesesashimi
- umohnani8
- LorbusChris
- RishabhSaini
- isabella-janssen
- pablintino
reviewers:
- djoshy
- dkhater-redhat
- yuqi-zhang
- cheesesashimi
- umohnani8
- LorbusChris
- RishabhSaini
- isabella-janssen
- pablintino
8 changes: 4 additions & 4 deletions test/extended/machine_config/boot_image_update_agnostic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (

func AllMachineSetTest(oc *exutil.CLI, fixture string) {
// This fixture applies a boot image update configuration that opts in all machinesets
ApplyBootImageFixture(oc, fixture)
ApplyMachineConfigurationFixture(oc, fixture)

// Step through all machinesets and verify boot images are reconciled correctly.
machineClient, err := machineclient.NewForConfig(oc.KubeFramework().ClientConfig())
Expand All @@ -34,7 +34,7 @@ func AllMachineSetTest(oc *exutil.CLI, fixture string) {
func PartialMachineSetTest(oc *exutil.CLI, fixture string) {

// This fixture applies a boot image update configuration that opts in any machineset with the label test=boot
ApplyBootImageFixture(oc, fixture)
ApplyMachineConfigurationFixture(oc, fixture)

// Pick a random machineset to test
machineClient, err := machineclient.NewForConfig(oc.KubeFramework().ClientConfig())
Expand All @@ -61,7 +61,7 @@ func PartialMachineSetTest(oc *exutil.CLI, fixture string) {

func NoneMachineSetTest(oc *exutil.CLI, fixture string) {
// This fixture applies a boot image update configuration that opts in no machinesets, i.e. feature is disabled.
ApplyBootImageFixture(oc, fixture)
ApplyMachineConfigurationFixture(oc, fixture)

// Step through all machinesets and verify boot images are reconciled correctly.
machineClient, err := machineclient.NewForConfig(oc.KubeFramework().ClientConfig())
Expand All @@ -77,7 +77,7 @@ func NoneMachineSetTest(oc *exutil.CLI, fixture string) {
func DegradeOnOwnerRefTest(oc *exutil.CLI, fixture string) {
e2eskipper.Skipf("This test is temporarily disabled until boot image skew enforcement is implemented")
// This fixture applies a boot image update configuration that opts in all machinesets
ApplyBootImageFixture(oc, fixture)
ApplyMachineConfigurationFixture(oc, fixture)

// Pick a random machineset to test
machineClient, err := machineclient.NewForConfig(oc.KubeFramework().ClientConfig())
Expand Down
2 changes: 1 addition & 1 deletion test/extended/machine_config/boot_image_update_aws.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var _ = g.Describe("[sig-mco][OCPFeatureGate:ManagedBootImagesAWS][Serial]", fun
})

g.AfterEach(func() {
ApplyBootImageFixture(oc, emptyMachineSetFixture)
ApplyMachineConfigurationFixture(oc, emptyMachineSetFixture)
})

g.It("Should update boot images only on MachineSets that are opted in [apigroup:machineconfiguration.openshift.io]", func() {
Expand Down
2 changes: 1 addition & 1 deletion test/extended/machine_config/boot_image_update_gcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ var _ = g.Describe("[sig-mco][OCPFeatureGate:ManagedBootImages][Serial]", func()

g.AfterEach(func() {
// Clear out boot image configuration between tests
ApplyBootImageFixture(oc, emptyMachineSetFixture)
ApplyMachineConfigurationFixture(oc, emptyMachineSetFixture)
})

g.It("Should update boot images only on MachineSets that are opted in [apigroup:machineconfiguration.openshift.io]", func() {
Expand Down
Loading