Run E2E tests for codeflare operator #40441

jiripetrlik · 2023-06-19T10:37:14Z

issue: project-codeflare/codeflare-operator#142

openshift-ci-robot · 2023-06-19T10:38:12Z

[REHEARSALNOTIFIER]
@jiripetrlik: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-project-codeflare-codeflare-operator-main-e2e-hypershift	project-codeflare/codeflare-operator	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

jiripetrlik · 2023-06-19T10:40:28Z

@anishasthana @astefanutti @sutaakar
Still WIP, but I will appreciate any feedback.

openshift-ci · 2023-06-19T10:41:35Z

Hi @jiripetrlik. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-06-19T10:41:45Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiripetrlik
Once this PR has been reviewed and has the lgtm label, please assign kpostoffice for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

ci-operator/config/project-codeflare/codeflare-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sutaakar · 2023-06-19T11:25:06Z

...r/config/project-codeflare/codeflare-operator/project-codeflare-codeflare-operator-main.yaml

+          echo Deploying KubeRay ${KUBERAY_VERSION}
+          kubectl create -k "github.com/ray-project/kuberay/ray-operator/config/default?ref=${KUBERAY_VERSION}&timeout=90s"
+          echo Deploying CodeFlare operator
+          IMG="${REGISTRY_ADDRESS}"/codeflare-operator


A nitpick, can you put some version to the image tag?

sutaakar · 2023-06-19T11:29:06Z

...r/config/project-codeflare/codeflare-operator/project-codeflare-codeflare-operator-main.yaml

+          cpu: 100m
+          memory: 200Mi


Based on https://github.com/opendatahub-io/distributed-workloads/blob/main/Quick-Start.md I would consider 4 CPU and at least 4Gi memory (considering just MCAD, Ray and CodeFlare operator now).

astefanutti · 2023-06-19T12:02:59Z

...r/config/project-codeflare/codeflare-operator/project-codeflare-codeflare-operator-main.yaml

@@ -28,6 +28,72 @@ tests:
        requests:
          cpu: 100m
          memory: 200Mi
+    - as: codeflare-operator-e2e
+      commands: |
+          podman run -d -p 5000:5000 --name registry registry:2.8.1


If possible, we'd want to rely on the OpenShift internal container image registry. So instead of starting a local one, we'd only need to expose and login to the internal registry, e.g.:

$ oc patch configs.imageregistry.operator.openshift.io/cluster --patch '{"spec":{"defaultRoute":true}}' --type=merge $ podman login -u kubeadmin -p $(oc whoami -t) $(oc registry info)

astefanutti · 2023-06-19T12:04:04Z

...r/config/project-codeflare/codeflare-operator/project-codeflare-codeflare-operator-main.yaml

+          echo Deploying CodeFlare operator
+          IMG="${REGISTRY_ADDRESS}"/codeflare-operator
+          make image-push -e IMG="${IMG}"
+          make deploy -e IMG="${IMG}"


If we rely on the OpenShift internal container registry, it'd need to be the internally addressable image.

anishasthana · 2023-06-22T14:41:09Z

/ok-to-test

openshift-bot · 2023-08-14T02:10:31Z

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-merge-robot · 2023-08-14T02:10:44Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-08-30T21:21:00Z

@jiripetrlik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ci-operator-config-metadata	`1361494`	link	true	`/test ci-operator-config-metadata`
ci/build-farm/build01-dry	`1361494`	link	true	`/test build01-dry`
ci/build-farm/build04-dry	`1361494`	link	true	`/test build04-dry`
ci/build-farm/vsphere02-dry	`1361494`	link	true	`/test vsphere02-dry`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-09-15T14:37:36Z

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2023-09-30T20:15:36Z

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2023-09-30T20:16:31Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Run E2E tests for codeflare operator

1361494

issue: project-codeflare/codeflare-operator#142

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2023

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 19, 2023

sutaakar reviewed Jun 19, 2023

View reviewed changes

astefanutti reviewed Jun 19, 2023

View reviewed changes

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2023

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2023

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 15, 2023

openshift-ci bot closed this Sep 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Run E2E tests for codeflare operator #40441

Run E2E tests for codeflare operator #40441

Uh oh!

jiripetrlik commented Jun 19, 2023

Uh oh!

openshift-ci-robot commented Jun 19, 2023

Uh oh!

jiripetrlik commented Jun 19, 2023

Uh oh!

openshift-ci bot commented Jun 19, 2023

Uh oh!

openshift-ci bot commented Jun 19, 2023

Uh oh!

sutaakar Jun 19, 2023

Uh oh!

sutaakar Jun 19, 2023

Uh oh!

astefanutti Jun 19, 2023

Uh oh!

astefanutti Jun 19, 2023

Uh oh!

anishasthana commented Jun 22, 2023

Uh oh!

openshift-bot commented Aug 14, 2023

Uh oh!

openshift-merge-robot commented Aug 14, 2023

Uh oh!

openshift-ci bot commented Aug 30, 2023

Uh oh!

openshift-bot commented Sep 15, 2023

Uh oh!

openshift-bot commented Sep 30, 2023

Uh oh!

openshift-ci bot commented Sep 30, 2023

Uh oh!

Uh oh!

Run E2E tests for codeflare operator #40441

Run E2E tests for codeflare operator #40441

Uh oh!

Conversation

jiripetrlik commented Jun 19, 2023

Uh oh!

openshift-ci-robot commented Jun 19, 2023

Uh oh!

jiripetrlik commented Jun 19, 2023

Uh oh!

openshift-ci bot commented Jun 19, 2023

Uh oh!

openshift-ci bot commented Jun 19, 2023

Uh oh!

sutaakar Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

sutaakar Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

astefanutti Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

astefanutti Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

anishasthana commented Jun 22, 2023

Uh oh!

openshift-bot commented Aug 14, 2023

Uh oh!

openshift-merge-robot commented Aug 14, 2023

Uh oh!

openshift-ci bot commented Aug 30, 2023

Uh oh!

openshift-bot commented Sep 15, 2023

Uh oh!

openshift-bot commented Sep 30, 2023

Uh oh!

openshift-ci bot commented Sep 30, 2023

Uh oh!

Uh oh!