Skip to content

Set target architecture build arg set to 'amd64' for devfile registry operator image builds #46896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

michael-valdron
Copy link
Member

Description

Changes to support multiple architectures for the devfile registry operator (devfile/registry-operator#68) is causing OpenShift CI testing to fail due to TARGETARCH build argument being overridden with a blank value.

This requires TARGETARCH to be manually set to the intended architecture for testing in OpenShift CI, currently only amd64.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@michael-valdron
Copy link
Member Author

/pj-rehearse

@michael-valdron michael-valdron force-pushed the feat/devfile-ro-arch-build-arg branch from 522e647 to 3620d12 Compare December 18, 2023 19:02
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@michael-valdron: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-devfile-registry-operator-release-v0-v4.12-images devfile/registry-operator presubmit Ci-operator config changed
pull-ci-devfile-registry-operator-release-v0-v4.12-registry-operator-integration-test devfile/registry-operator presubmit Ci-operator config changed
pull-ci-devfile-registry-operator-main-v4.12-images devfile/registry-operator presubmit Ci-operator config changed
pull-ci-devfile-registry-operator-main-v4.12-registry-operator-integration-test devfile/registry-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@michael-valdron
Copy link
Member Author

/pj-rehearse

@michael-valdron
Copy link
Member Author

Folded these changes into #46895.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants