Skip to content

cluster-ingress-operator: Run HyperShift conformance tests #64335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

cluster-ingress-operator: Run HyperShift conformance tests #64335

merged 1 commit into from
May 15, 2025

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Apr 28, 2025 •
edited
Loading

Add HyperShift conformance testing as a required presubmit job to catch regressions early for HyperShift cluster profile.

Similar to #63810.
Follow up of the revert of GatewayAPI promotion.

@openshift-ci openshift-ci bot requested review from frobware and knobunc April 28, 2025 14:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025
@alebedev87
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@alebedev87
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 28, 2025
@candita
Copy link
Contributor

candita commented Apr 30, 2025

/assign @grzpiotrowski

@alebedev87
cluster-ingress-operator: Run HyperShift conformance tests
6a83ee9 
Add HyperShift conformance testing as a required presubmit job
to catch regressions early for HyperShift cluster profile.
@alebedev87 alebedev87 force-pushed the cio-hypershift-conformance branch from ccfd3da to 6a83ee9 Compare May 14, 2025 15:31
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@alebedev87: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-hypershift-conformance openshift/cluster-ingress-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@alebedev87
Copy link
Contributor Author

/pj-rehearse ack

I had to rebase due to a rebase conflict.

@openshift-ci-robot
Copy link
Contributor

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2025

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

grzpiotrowski
grzpiotrowski approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@grzpiotrowski grzpiotrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and compared against similar work as a reference.

/approve
/lgtm

@grzpiotrowski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, grzpiotrowski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2540753 into openshift:master May 15, 2025
15 checks passed
tbuskey pushed a commit to tbuskey/release that referenced this pull request May 19, 2025
@alebedev87 @tbuskey
cluster-ingress-operator: Run HyperShift conformance tests (openshift…
64c1b9a 
…#64335)

Add HyperShift conformance testing as a required presubmit job
to catch regressions early for HyperShift cluster profile.
abraham2512 pushed a commit to abraham2512/release that referenced this pull request May 29, 2025
@alebedev87 @abraham2512
cluster-ingress-operator: Run HyperShift conformance tests (openshift…
0cd0b56 
…#64335)

Add HyperShift conformance testing as a required presubmit job
to catch regressions early for HyperShift cluster profile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@knobunc knobunc Awaiting requested review from knobunc

1 more reviewer

@grzpiotrowski grzpiotrowski grzpiotrowski approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@grzpiotrowski grzpiotrowski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alebedev87 @openshift-ci-robot @candita @grzpiotrowski