OTA-1478 add 4.20 ota jobs #65512

dis016 · 2025-05-30T09:22:06Z

OTA-1478 add 4.20 ota jobs

openshift-ci · 2025-05-30T09:22:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dis016
Once this PR has been reviewed and has the lgtm label, please assign gpei for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dis016 · 2025-05-30T10:25:50Z

/hold for review and rehearse jobs

jiajliu · 2025-06-04T06:21:17Z

...tests/openshift-verification-tests-main__ota-multi-stable-4.20-upgrade-from-stable-4.19.yaml

+    release:
+      architecture: multi
+      channel: candidate
+      version: "4.21"


I guess this will break 4.20 ci tests in the job config, could you trigger some tests under openshift-verification-tests-main__ota-multi-stable-4.20-upgrade-from-stable-4.19.yaml to have a try?

@dis016 what are your follow up actions to address this?

@dis016 I think you can create a new JIRA card to track the work which requires OCP 4.21, and implement jobs only when there are OCP 4.21 payloads.

For this PR, you can just remove this version.

@jhou1 as @jiajliu suspected there is a problem in generating the release images for the jobs, i will work on it and correct the parameters to fix the same.

The issue was introduced by #58136. Dropping it when enable 4.20 test and then add it back someday sounds a workaround. But the issue will come back again when enable 4.21/4.22.. test.
Personally I think it will bring the team endless maintenance work. cc @JianLi-RH to consider fixing the test from code level. Actually 4.21 is not an upgrade target for path 4.20.0 -> 4.20.latest -> 4.21, which is not required to be configured in job level. We should rely on a long-term resolution to reduce team's maintenance work.

dis016 · 2025-06-04T06:23:52Z

/pj-rehearse periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-azure-ipi-amd-mixarch-f28

openshift-ci-robot · 2025-06-04T06:23:55Z

@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

dis016 · 2025-06-16T05:05:04Z

/pj-rehearse periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-azure-ipi-amd-mixarch-f28

openshift-ci-robot · 2025-06-16T05:05:07Z

@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

dis016 · 2025-06-16T05:34:30Z

/pj-rehearse periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-azure-ipi-amd-mixarch-f28

openshift-ci-robot · 2025-06-16T05:34:33Z

@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

dis016 · 2025-06-17T04:16:06Z

/pj-rehearse periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-azure-ipi-amd-mixarch-f28

openshift-ci-robot · 2025-06-17T04:16:08Z

@dis016: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci-robot · 2025-06-17T04:20:12Z

[REHEARSALNOTIFIER]
@dis016: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-baremetal-ipi-retarget-f28	N/A	periodic	Periodic changed
periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-azure-ipi-amd-mixarch-f28	N/A	periodic	Periodic changed
periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-gcp-ipi-retarget-f28	N/A	periodic	Periodic changed
periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-aws-ipi-amd-tolatest-f28	N/A	periodic	Periodic changed
periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.20-baremetal-ipi-retarget-f28	N/A	periodic	Periodic changed
periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.20-gcp-ipi-retarget-f28	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2025-06-17T04:34:19Z

@dis016: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ordered-prow-config	`e46563e`	link	true	`/test ordered-prow-config`
ci/rehearse/periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-azure-ipi-amd-mixarch-f28	`52dca0a`	link	unknown	`/pj-rehearse periodic-ci-openshift-verification-tests-main-ota-multi-stable-4.20-upgrade-from-stable-4.19-azure-ipi-amd-mixarch-f28`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

JianLi-RH · 2025-06-30T01:34:41Z

...tests/openshift-verification-tests-main__ota-multi-stable-4.20-upgrade-from-stable-4.20.yaml

+      relative: 1
+      version_bounds:
+        lower: 4.20.0-0
+        stream: 4-stable


Right now, the stream should be 4-dev-preview.

JianLi-RH · 2025-06-30T01:39:17Z

...tests/openshift-verification-tests-main__ota-multi-stable-4.20-upgrade-from-stable-4.20.yaml

+      commands: echo "${INTERMEDIATE_RETARGET}" > ${SHARED_DIR}/upgrade-edge
+      dependencies:
+      - env: INTERMEDIATE_RETARGET
+        name: release:intermediate1


If you use intermediate1 in gcp-ipi-retarget-f28, then the tests is duplicate with baremetal-ipi-retarget-f28.
But anyway, you can temporarily using intermediate1, but don't forget update it to intermediate2 when there are OCP 4.21 payloads.

intermediate1 meant to test: 4.20.0 -> 4.20.n -> 4.20.(n+1)
but intermediate2 meant to test: 4.20.0 -> 4.20.latest -> 4.21

JianLi-RH · 2025-06-30T01:40:43Z

...tests/openshift-verification-tests-main__ota-multi-stable-4.20-upgrade-from-stable-4.19.yaml

+      relative: 1
+      version_bounds:
+        lower: 4.20.0-0
+        stream: 4-stable


Right now, the stream should be 4-dev-preview.

JianLi-RH · 2025-06-30T01:42:07Z

...tests/openshift-verification-tests-main__ota-multi-stable-4.20-upgrade-from-stable-4.19.yaml

+      commands: echo "${INTERMEDIATE_RETARGET}" > ${SHARED_DIR}/upgrade-edge
+      dependencies:
+      - env: INTERMEDIATE_RETARGET
+        name: release:intermediate1


See my comment in below file.

add 4.20 ota jobs

ca6b783

openshift-ci bot requested review from jhou1, jiajliu and JianLi-RH May 30, 2025 09:22

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2025

jiajliu reviewed Jun 4, 2025

View reviewed changes

use only 4.20

5fa6327

test

31f0858

test

52dca0a

Merge branch 'openshift:master' into OTA-1478_add_ota_jobs_4.20

e46563e

JianLi-RH reviewed Jun 30, 2025

View reviewed changes

OTA-1478 add 4.20 ota jobs #65512

Are you sure you want to change the base?

OTA-1478 add 4.20 ota jobs #65512

Conversation

dis016 commented May 30, 2025

Uh oh!

openshift-ci bot commented May 30, 2025

Uh oh!

dis016 commented May 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dis016 commented Jun 4, 2025

Uh oh!

openshift-ci-robot commented Jun 4, 2025

Uh oh!

dis016 commented Jun 16, 2025

Uh oh!

openshift-ci-robot commented Jun 16, 2025

Uh oh!

dis016 commented Jun 16, 2025

Uh oh!

openshift-ci-robot commented Jun 16, 2025

Uh oh!

dis016 commented Jun 17, 2025

Uh oh!

openshift-ci-robot commented Jun 17, 2025

Uh oh!

openshift-ci-robot commented Jun 17, 2025

Uh oh!

openshift-ci bot commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!