Skip to content

SPLAT-2157: Azure Multi Disk with etcd #65531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented May 30, 2025

This PR:

@jcpowermac
Copy link
Contributor Author

testing this pr: openshift/installer#9706

@openshift-ci openshift-ci bot requested review from andfasano and sadasu May 30, 2025 19:11
@jcpowermac jcpowermac force-pushed the azure-etcd-multidisk branch from 93471ee to d787b75 Compare May 30, 2025 19:18
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jcpowermac: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-prometheus-operator-main-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.21-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.20-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.19-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.18-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.17-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.16-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.15-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.14-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.13-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.12-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.11-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.10-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-prometheus-operator-release-4.9-e2e-agnostic-cmo openshift/prometheus-operator presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-4.15-e2e-deploy openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-4.15-e2e-upgrade openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-4.12-e2e-deploy openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-4.12-e2e-upgrade openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-e2e-deploy openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-e2e-upgrade openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-4.16-e2e-deploy openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-4.16-e2e-upgrade openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-4.14-e2e-deploy openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-4.14-e2e-upgrade openshift-cnv/cnv-ci presubmit Registry content changed
pull-ci-openshift-cnv-cnv-ci-master-4.10-e2e-deploy openshift-cnv/cnv-ci presubmit Registry content changed

A total of 3276 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jcpowermac
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-azure-ovn

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: job(s): periodic-ci-openshift-release-master-nightly-4.20-e2e-azure-ovn either don't exist or were not found to be affected, and cannot be rehearsed

@jcpowermac
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-ovn

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcpowermac
Copy link
Contributor Author

/assign @patrickdillon

@vr4manta
Copy link
Contributor

vr4manta commented Jun 3, 2025

/pj-rehearse pull-ci-openshift-installer-release-4.20-e2e-azure-ovn-multidisk-techpreview

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vr4manta
Copy link
Contributor

vr4manta commented Jun 3, 2025

/lgtm

Based on discussions, the rehearse of the new job will fail until the installer PR merges.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2025
Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac, vr4manta
Once this PR has been reviewed and has the lgtm label, please ask for approval from patrickdillon. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta
Copy link
Contributor

vr4manta commented Jun 3, 2025

/payload-job-with-prs pull-ci-openshift-installer-release-4.20-e2e-azure-ovn-multidisk-techpreview openshift/installer#9706

Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

@vr4manta: the repo openshift/release does not contribute to the OpenShift official images

@jcpowermac jcpowermac changed the title Azure Multi Disk with etcd SPLAT-2157: Azure Multi Disk with etcd Jun 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 3, 2025

@jcpowermac: This pull request references SPLAT-2157 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This PR:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants