Skip to content

SPLAT-2340: Disable storage operator for hybrid env during install #67359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SPLAT-2340: Disable storage operator for hybrid env during install #67359

wants to merge 5 commits into from
+108 −3

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Jul 22, 2025 •
edited
Loading

SPLAT-2340

Changes

  • Made all hybrid jobs disable storage (and other) capabilities.
  • Enabled storage operator after updating vsphere nodes with expected label
  • Disabled persistence for monitoring and registry due to disabling storage operator

Notes

hybrid jobs that run storage operator will still fail until the vmware vsphere csi driver operator changes for daemonsets is merged.

This PR is disabling many capabilities as a way to test how running tests w/o them will work. This may be consumed later for more vSphere jobs to reduce image pulls for jobs that are not testing all the capabilities.

Disabling the storage operator is just a temporary workaround until the upstream PR for cloud-provider-vsphere merges. That PR allows openshift to provide a list of additional labels to add to a node so that pods / deployments / daemonsets can use a nodeSelector to target vSphere specific nodes in a hybrid env.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 22, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 22, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2340 which is a valid jira issue.

In response to this:

SPLAT-2340

Changes

  • Added new HYBRID_ENV variable for hybrid logic
  • Disabled storage operator when installing hybrid env
  • Activated storage operator during BM provisioning

Notes

This PR is adding a new variable that is allowing us to attempt to disable the storage operator until we have flagged all nodes as vsphere due to upstream PR not being merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhixson74 and smg247 July 22, 2025 17:50
@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vr4manta
Copy link
Contributor Author

/hold
Need to fix an issue where hybrid not rolling out when storage disabled due to monitoring wanting a PV thats not getting fulfilled.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2025
@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rvanderp3
rvanderp3 reviewed Jul 23, 2025
View reviewed changes
ci-operator/config/openshift-priv/installer/openshift-priv-installer-main.yaml
@@ -1043,9 +1043,13 @@ tests:
steps:
cluster_profile: vsphere-elastic
env:
ADDITIONAL_ENABLED_CAPABILITIES: MachineAPI CloudControllerManager Ingress CloudCredential
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgaoshang @WenXinWei any concerns with the strategy of disabling some capabilities for vSphere presubmits?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as doc mentioned, admin can disable optional components prior to installation, and enable after installation. so i thinks it looks good to me.

@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2340 which is a valid jira issue.

In response to this:

SPLAT-2340

Changes

  • Made all hybrid jobs disable storage (and other) capabilities.
  • Enabled storage operator after updating vsphere nodes with expected label
  • Disabled persistence for monitoring and registry due to disabling storage operator

Notes

hybrid jobs will still fail until the vmware vsphere csi driver operator changes for daemonsets is merged.

This PR is disabling many capabilities as a way to test how running tests w/o them will work. This may be consumed later for more vSphere jobs to reduce image pulls for jobs that are not testing all the capabilities.

Disabling the storage operator is just a temporary workaround until the upstream PR for cloud-provider-vsphere merges. That PR allows openshift to provide a list of additional labels to add to a node so that pods / deployments / daemonsets can use a nodeSelector to target vSphere specific nodes in a hybrid env.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@vr4manta: job(s): periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vr4manta
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon, vrutkovs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2340 which is a valid jira issue.

In response to this:

SPLAT-2340

Changes

  • Made all hybrid jobs disable storage (and other) capabilities.
  • Enabled storage operator after updating vsphere nodes with expected label
  • Disabled persistence for monitoring and registry due to disabling storage operator

Notes

hybrid jobs that run storage operator will still fail until the vmware vsphere csi driver operator changes for daemonsets is merged.

This PR is disabling many capabilities as a way to test how running tests w/o them will work. This may be consumed later for more vSphere jobs to reduce image pulls for jobs that are not testing all the capabilities.

Disabling the storage operator is just a temporary workaround until the upstream PR for cloud-provider-vsphere merges. That PR allows openshift to provide a list of additional labels to add to a node so that pods / deployments / daemonsets can use a nodeSelector to target vSphere specific nodes in a hybrid env.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

/unhold
hybrid tests are running as expected. New changes are now allowing agnostic node to attach and run tests when storage is disabled.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vr4manta
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere-csi-hybrid-env openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.21-e2e-vsphere-csi-hybrid-env openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.20-e2e-vsphere-csi-hybrid-env openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-main-e2e-vsphere-ovn-hybrid-env openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.21-e2e-vsphere-ovn-hybrid-env openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.20-e2e-vsphere-ovn-hybrid-env openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-installer-main-e2e-vsphere-ovn-hybrid-env openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.20-e2e-vsphere-ovn-hybrid-env openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.21-e2e-vsphere-ovn-hybrid-env openshift/installer presubmit Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-upi-hybrid-env N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env 1dd37c8 link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanderp3 rvanderp3 rvanderp3 left review comments

@WenXinWei WenXinWei WenXinWei left review comments

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@smg247 smg247 Awaiting requested review from smg247

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vr4manta @openshift-ci-robot @rvanderp3 @WenXinWei