Skip to content

Conversation

lucferbux
Copy link
Contributor

Description

We are onboarding a new module for odh-dashboard in rhoai. The outcome of this PR would be onboarding this module to have pre-submit and post-submit builds.

@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 19:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CI/CD configuration for a new modular architecture module (model-registry) for the odh-dashboard project. The changes establish pre-submit and post-submit build pipelines for the new module while also fixing existing target configurations in the main pipeline.

  • Adds CI configuration for the new mod-arch-model-registry module
  • Creates pre-submit and post-submit job definitions for the model-registry module
  • Fixes target specification in existing main pipeline jobs

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
opendatahub-io-odh-dashboard-mod-arch-model-registry-main-presubmits.yaml Defines pre-submit jobs for the model-registry module with image mirroring
opendatahub-io-odh-dashboard-mod-arch-model-registry-main-postsubmits.yaml Defines post-submit jobs for the model-registry module with promotion
opendatahub-io-odh-dashboard-main-presubmits.yaml Updates target from generic [images] to specific odh-dashboard-image
opendatahub-io-odh-dashboard-main-postsubmits.yaml Updates target from generic [images] to specific odh-dashboard-image
opendatahub-io-odh-dashboard-mod-arch-model-registry-main.yaml Adds CI operator configuration for the model-registry module build

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2025
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

Hi @lucferbux. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lucferbux
Once this PR has been reviewed and has the lgtm label, please assign christianvogt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@lucferbux, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: [invalid presubmit job pull-ci-opendatahub-io-odh-dashboard-main__mod-arch-model-registry-odh-mod-arch-model-registry-pr-image-mirror: volume gcs-credentials is a reserved for decoration, invalid postsubmit job branch-ci-opendatahub-io-odh-dashboard-main__mod-arch-model-registry-odh-mod-arch-model-registry-image: volume gcs-credentials is a reserved for decoration]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from jrenee42 and ppadti September 4, 2025 19:27
@lucferbux lucferbux force-pushed the mod-arch-modular-architecture branch from 360de18 to 6a194f6 Compare September 4, 2025 19:30
@openshift-ci-robot
Copy link
Contributor

@lucferbux, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: [invalid presubmit job pull-ci-opendatahub-io-odh-dashboard-main__mod-arch-model-registry-odh-mod-arch-model-registry-pr-image-mirror: volume gcs-credentials is a reserved for decoration, invalid postsubmit job branch-ci-opendatahub-io-odh-dashboard-main__mod-arch-model-registry-odh-mod-arch-model-registry-image: volume gcs-credentials is a reserved for decoration]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@lucferbux lucferbux changed the title Add new module for modular architecture MR WIP: Add new module for modular architecture MR Sep 5, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants