-
Notifications
You must be signed in to change notification settings - Fork 2k
WIP: Add new module for modular architecture MR #68914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WIP: Add new module for modular architecture MR #68914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds CI/CD configuration for a new modular architecture module (model-registry) for the odh-dashboard project. The changes establish pre-submit and post-submit build pipelines for the new module while also fixing existing target configurations in the main pipeline.
- Adds CI configuration for the new mod-arch-model-registry module
- Creates pre-submit and post-submit job definitions for the model-registry module
- Fixes target specification in existing main pipeline jobs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
opendatahub-io-odh-dashboard-mod-arch-model-registry-main-presubmits.yaml | Defines pre-submit jobs for the model-registry module with image mirroring |
opendatahub-io-odh-dashboard-mod-arch-model-registry-main-postsubmits.yaml | Defines post-submit jobs for the model-registry module with promotion |
opendatahub-io-odh-dashboard-main-presubmits.yaml | Updates target from generic [images] to specific odh-dashboard-image |
opendatahub-io-odh-dashboard-main-postsubmits.yaml | Updates target from generic [images] to specific odh-dashboard-image |
opendatahub-io-odh-dashboard-mod-arch-model-registry-main.yaml | Adds CI operator configuration for the model-registry module build |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hi @lucferbux. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lucferbux,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
…gistry configuration
360de18
to
6a194f6
Compare
@lucferbux,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Description
We are onboarding a new module for odh-dashboard in rhoai. The outcome of this PR would be onboarding this module to have pre-submit and post-submit builds.