Skip to content

CMP-3385: Consolidate periodic testing for 4.17, 4.18, add periodic testing for 4.19 #68943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CMP-3385: Consolidate periodic testing for 4.17, 4.18, add periodic testing for 4.19 #68943

wants to merge 3 commits into from
+189 −3,625

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Sep 5, 2025 •
edited by openshift-ci bot
Loading

  • CMP-3385: Consolidate 4.17 periodic profile jobs
  • CMP-3385: Consolidate 4.18 periodic profile jobs
  • CMP-3385: Add periodic platform and node testing for 4.19

@rhmdnd
CMP-3385: Consolidate 4.17 periodic profile jobs
c0f1690 
Instead of running each profile on 4.17, let's put all the rules in a
single tailored profile and exercise them. This cuts down on the number
of environments we need to spin up and the number duplicate findings
when the same rule fails in multiple profiles for the same reason.
@rhmdnd
CMP-3385: Consolidate 4.18 periodic profile jobs
e297b6a 
Instead of running each profile on 4.18, let's put all the rules in a
single tailored profile and exercise them. This cuts down on the number
of environments we need to spin up and the number duplicate findings
when the same rule fails in multiple profiles for the same reason.
@rhmdnd
CMP-3385: Add periodic platform and node testing for 4.19
cc68777 
Let's test all the platform and node rules twice a week on 4.19 so we
can establish a baseline compliance posture compared to other OCP
versions.
@rhmdnd rhmdnd changed the title CMP 3385 4.17 4.19 CMP-3385: Consolidate periodic testing for 4.17, 4.18, add periodic testing for 4.19 Sep 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 5, 2025 •
edited by openshift-ci bot
Loading

@rhmdnd: This pull request references CMP-3385 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

  • CMP-3385: Consolidate 4.17 periodic profile jobs
  • CMP-3385: Consolidate 4.18 periodic profile jobs
  • CMP-3385: Add periodic platform and node testing for 4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 5, 2025
@openshift-ci openshift-ci bot requested review from droslean and smg247 September 5, 2025 13:51
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rhmdnd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-ComplianceAsCode-content-master-4.19-e2e-aws-openshift-platform-compliance-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.18-e2e-aws-openshift-platform-compliance-arm-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.19-e2e-aws-openshift-node-compliance-arm-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.19-e2e-aws-openshift-node-compliance-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.19-e2e-aws-openshift-platform-compliance-arm-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.18-e2e-aws-openshift-node-compliance-arm-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.17-e2e-aws-openshift-node-compliance-arm-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.17-e2e-aws-openshift-node-compliance-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.18-e2e-aws-openshift-platform-compliance-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.18-e2e-aws-openshift-node-compliance-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.17-e2e-aws-openshift-platform-compliance-arm-weekly N/A periodic Periodic changed
periodic-ci-ComplianceAsCode-content-master-4.17-e2e-aws-openshift-platform-compliance-weekly N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Sep 5, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@rhmdnd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-ComplianceAsCode-content-master-4.19-e2e-aws-openshift-node-compliance-weekly cc68777 link unknown /pj-rehearse periodic-ci-ComplianceAsCode-content-master-4.19-e2e-aws-openshift-node-compliance-weekly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Sep 5, 2025

4.19 node rehearsal failed updating the node pools:

 2025/09/05 16:46:14 Still waiting for MachineConfigPools to update after 5s: 1 MachineConfigPools still updating: [worker (Updated: 0/3, Unavailable: 2)]
2025/09/05 16:46:19 Timeout reached after 60 minutes waiting for MachineConfigPools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droslean droslean Awaiting requested review from droslean

@smg247 smg247 Awaiting requested review from smg247

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhmdnd @openshift-ci-robot