Skip to content

Conversation

rphillips
Copy link
Contributor

@rphillips rphillips commented Sep 5, 2025

Adds a retry to fetching the package manifest within the cert-manager step registry. This PR preserves the same logic and has a 2 minute timeout.

* will quit after two minutes and up to 6 retries
@openshift-ci openshift-ci bot requested review from lunarwhite and swghosh September 5, 2025 20:31
@kannon92
Copy link
Contributor

kannon92 commented Sep 5, 2025

We are hitting this failure a lot in our CI when installing cert-manager.

Sometimes there is no package manifests.

We had this change in our internal script for cert manager so we are pushing this here.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92, rphillips
Once this PR has been reviewed and has the lgtm label, please assign lunarwhite for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rphillips: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kueue-operator-release-1.1-test-e2e-4-17 openshift/kueue-operator presubmit Registry content changed
pull-ci-openshift-kueue-operator-release-1.0-test-e2e-4-17 openshift/kueue-operator presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.19-aws-ipi-byo-iam-role-efs-mini-perm-arm-f60-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f28-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-4.18-upgrade-from-stable-4.17-aws-ipi-byo-iam-role-efs-fips-amd-f28-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-gcp-ipi-disk-encryption-arm-f14-cert-manager-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-kueue-operator-main-test-e2e-4-19 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.18-aws-ipi-byo-iam-role-efs-fips-amd-f28-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-kueue-operator-release-1.0-test-e2e-disconnected N/A periodic Registry content changed
periodic-ci-openshift-kueue-operator-release-1.1-test-e2e-disconnected N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f14-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f7-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f7-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-multi-nightly-aws-ipi-byo-iam-role-efs-arm-f14-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-byo-iam-role-efs-mini-perm-arm-f7-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-kueue-operator-main-test-e2e-4-19-hypershift N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-4.20-upgrade-from-stable-4.20-aws-ipi-byo-iam-role-efs-mini-perm-arm-f60-custom-cert N/A periodic Registry content changed
periodic-ci-openshift-kueue-operator-release-1.0-test-e2e-4-18 N/A periodic Registry content changed
periodic-ci-openshift-kueue-operator-release-1.0-test-e2e-4-19 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-4.20-upgrade-from-stable-4.19-aws-ipi-byo-iam-role-efs-fips-amd-f28-custom-cert N/A periodic Registry content changed

A total of 33 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rphillips rphillips changed the title cert-manager: add retry for getting the package packagemanifest cert-manager: add retry for getting the packagemanifest Sep 5, 2025
@rphillips
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-kueue-operator-main-test-e2e-4-19

@openshift-ci-robot
Copy link
Contributor

@rphillips: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@swghosh
Copy link
Member

swghosh commented Sep 5, 2025

/cc @lunarwhite

Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@rphillips: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants