-
Notifications
You must be signed in to change notification settings - Fork 296
use plover_stroke
#1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benoit-pierre
merged 19 commits into
opensteno:master
from
benoit-pierre:use_plover_stroke
Oct 10, 2021
Merged
use plover_stroke
#1362
benoit-pierre
merged 19 commits into
opensteno:master
from
benoit-pierre:use_plover_stroke
Oct 10, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think this take care of #672. |
f68358d to
cb6e07f
Compare
This was referenced Jun 22, 2021
Merged
5ff6e01 to
2512c38
Compare
Member
|
Looks good to me! |
So there's no need for dedicated support code in `system.setup`.
Use `steno_to_sort_key` so the system' steno order is respected.
Just use `Stroke.from_steno`.
2512c38 to
454b225
Compare
This was referenced Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The next version of
plover_stroke(1.0.0) has been rewritten to use a CPython extension, making it possible to use it for thestenomodule implementation without negatively impacting the performance (particularly loading times).Pros:
steno.Stroke,normalize_steno, andplover_build_utils.testing.steno_to_strokesteno_to_sort_keyfor sorting on steno order (used by the dictionary editor)main.json)Cons:
plover_strokesupport a maximum of 63 keysplover_stroke(but binary wheels for common platforms / Python versions are provided)TODO:
steno_to_sort_keyfor sorting on JSON dictionary savegui_qt.steno_validatorPull Request Checklist