ci(build): fix theme concat error #2145

zzcr · 2024-09-19T01:41:30Z

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Chores
- Simplified development and build processes by removing the gulp themeConcat command from multiple scripts.
- Updated scripts now directly utilize pnpm commands for building and running examples.

coderabbitai · 2024-09-19T01:41:36Z

Walkthrough

The changes in this pull request involve the removal of the gulp themeConcat -w command from multiple development scripts in the package.json file. This command, which was used for watching and concatenating themes during development, has been eliminated from scripts such as dev, dev2, site, and others. The modifications aim to streamline the development and build processes by directly utilizing pnpm commands without the background execution of theme concatenation.

Changes

File	Change Summary
package.json	Removed `gulp themeConcat -w` from `dev`, `dev2`, `dev2.7`, `site`, `site:open`, `site:mobile`, `build:ui`, `build:theme`, and `build:site`.

Possibly related PRs

fix(input): [input] fix textarea x-design style #2076: This PR modifies the CSS styling of textarea components, which may relate to the changes in the package.json that streamline the build process for UI components, including textareas.
fix(site): fixed the official website style exception and icon parse … #2105: This PR updates the package.json file, which is directly relevant to the changes made in the main PR regarding the removal of certain commands in development scripts.

Suggested labels

bug

Poem

🐇 In the garden of code, we hop and play,
Removing the clutter, making way!
With gulp now gone, our scripts run free,
Building with pnpm, as happy as can be!
Let's celebrate changes, both swift and bright,
A cleaner path forward, oh what a delight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai generate interesting stats about this repository and render them as a table.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-09-19T01:42:17Z

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3e24748 and 22cb054.

Files selected for processing (1)

package.json (2 hunks)

Additional comments not posted (2)

package.json (2)

38-38: Ensure theme concatenation is handled after removing 'gulp themeConcat -w &'

The scripts dev, dev2, dev2.7, site, site:open, and site:mobile no longer include gulp themeConcat -w &. Please verify that theme concatenation is still performed appropriately to prevent any styling issues during development.

Also applies to: 40-40, 42-42, 45-45, 46-46, 48-48

62-62: Confirm theme generation occurs correctly without 'gulp themeConcat'

The scripts build:ui and build:theme have removed gulp themeConcat. Ensure that theme files are generated properly during the build process to avoid any styling issues in production.

Also applies to: 65-65

coderabbitai · 2024-09-19T01:45:19Z

package.json

    "build:themeSaas": "pnpm -C packages/theme-saas build:fast",
    "build:themeMobile": "pnpm -C packages/theme-mobile build:fast",
    "build:themejson": "gulp themeJson",
    "build:internals": "pnpm \"--filter=./internals/*\" build",
    "build:vite-import": "pnpm --filter @opentiny/vue-vite-import build",
    "build:virtual-template": "pnpm --filter @opentiny-internal/unplugin-virtual-template build",
-    "build:site": "gulp themeConcat && pnpm i -g pnpm && pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",
+    "build:site": "pnpm i -g pnpm && pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",


Consider removing global 'pnpm' installation in 'build:site' script

Including pnpm i -g pnpm in the build:site script may be unnecessary since pnpm is already being used to run the script. Installing packages globally within scripts can cause issues in environments with restricted permissions.

Apply this diff to update the script:

-"build:site": "pnpm i -g pnpm && pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build", +"build:site": "pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

"build:site": "pnpm i -g pnpm && pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",

"build:site": "pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",

ci(build): fix theme concat error

22cb054

coderabbitai bot reviewed Sep 19, 2024

View reviewed changes

kagol approved these changes Sep 19, 2024

View reviewed changes

kagol merged commit 6a298bc into dev Sep 19, 2024
9 of 11 checks passed

This was referenced Oct 21, 2024

build(charts): compatible with the old version of charts chart introd… #2327

Merged

docs: 删除smb配置以及相关依赖 #2332

Merged

kagol deleted the delete-themecat-0919 branch November 4, 2024 03:58

This was referenced Nov 30, 2024

ci: add auto deploy site #2582

Merged

ci: fix auto deploy site failed #2616

Closed

coderabbitai bot mentioned this pull request Dec 11, 2024

feat: sync 3.20.0 to dev #2639

Merged

13 tasks

coderabbitai bot mentioned this pull request Dec 18, 2024

fix(unplugin-tiny-vue): fix error TinyVueResolver name #2676

Merged

13 tasks

This was referenced Jan 2, 2025

build: update vite version and fix inline-chunk plugin #2722

Merged

【wip】feat: update vue repl for site #2730

Draft

feat: add utils packages type module #2731

Merged

ci(workflows): add runtime publish git-action #2764

Merged

This was referenced Jan 10, 2025

ci(workflows): support automated patch version tag #2773

Merged

chore: sync 3.21.0 to dev #2797

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(build): fix theme concat error #2145

ci(build): fix theme concat error #2145

zzcr commented Sep 19, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 19, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Sep 19, 2024

coderabbitai bot left a comment

coderabbitai bot Sep 19, 2024

	"build:site": "pnpm i -g pnpm && pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",
	"build:site": "pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",

ci(build): fix theme concat error #2145

ci(build): fix theme concat error #2145

Conversation

zzcr commented Sep 19, 2024 • edited by coderabbitai bot Loading

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

coderabbitai bot commented Sep 19, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Sep 19, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Sep 19, 2024

Choose a reason for hiding this comment

zzcr commented Sep 19, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 19, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)