Skip to content

ci(build): fix theme concat error #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024
+9 −9
Merged

ci(build): fix theme concat error #2145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,17 @@
"postinstall": "pnpm build:internals",
"prepare": "husky install",
"bootstrap": "pnpm --filter=\"!./packages/dist/**\" install",
"dev": "pnpm build:entry && gulp themeConcat -w & pnpm -C examples/vue3 dev",
"dev": "pnpm build:entry && pnpm -C examples/vue3 dev",
"dev:saas": "pnpm create:icon-saas && pnpm build:entry && pnpm -C examples/vue3 dev:saas",
"dev2": "pnpm build:entry && gulp themeConcat -w & pnpm -C examples/vue2 dev",
"dev2": "pnpm build:entry && pnpm -C examples/vue2 dev",
"dev2:saas": "pnpm create:icon-saas && pnpm build:entry && pnpm -C examples/vue2 dev:saas",
"dev2.7": "pnpm build:entry && gulp themeConcat -w & pnpm -C examples/vue2.7 dev",
"dev2.7": "pnpm build:entry && pnpm -C examples/vue2.7 dev",
"dev2.7:saas": "pnpm create:icon-saas && pnpm build:entry && pnpm -C examples/vue2.7 dev:saas",
"// ---------- 启动官网文档 ----------": "",
"site": "pnpm build:entry && gulp themeConcat -w & pnpm -C examples/sites start",
"site:open": "pnpm build:entry && gulp themeConcat -w & pnpm -C examples/sites start:open",
"site": "pnpm build:entry && pnpm -C examples/sites start",
"site:open": "pnpm build:entry && pnpm -C examples/sites start:open",
"// ---------- 启动移动端组件官网文档 ----------": "",
"site:mobile": "pnpm build:entry && gulp themeConcat -w & pnpm -C examples/sites start:mobile",
"site:mobile": "pnpm build:entry && pnpm -C examples/sites start:mobile",
"// ---------- 启动saas官网文档 ----------": "",
"site:saas": "pnpm create:icon-saas && pnpm build:entry && pnpm -C examples/sites start:saas",
"build:entry": "pnpm -C internals/cli build:entry",
Expand All @@ -59,17 +59,17 @@
"// ---------- 打包运行时组件库 ----------": "",
"build:runtime": "pnpm -C internals/cli build:runtime",
"// ---------- 构建相关脚本 ----------": "",
"build:ui": "pnpm create:icon-saas && pnpm create:mapping && pnpm build:entry && gulp themeConcat && pnpm -C internals/cli build:ui",
"build:ui": "pnpm create:icon-saas && pnpm create:mapping && pnpm build:entry && pnpm -C internals/cli build:ui",
"build:chartTheme": "pnpm -C internals/cli build:chartTheme",
"build:renderless": "pnpm -C packages/renderless build:fast",
"build:theme": "gulp themeConcat && pnpm -C packages/theme build:fast",
"build:theme": "pnpm -C packages/theme build:fast",
"build:themeSaas": "pnpm -C packages/theme-saas build:fast",
"build:themeMobile": "pnpm -C packages/theme-mobile build:fast",
"build:themejson": "gulp themeJson",
"build:internals": "pnpm \"--filter=./internals/*\" build",
"build:vite-import": "pnpm --filter @opentiny/vue-vite-import build",
"build:virtual-template": "pnpm --filter @opentiny-internal/unplugin-virtual-template build",
"build:site": "gulp themeConcat && pnpm i -g pnpm && pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",
"build:site": "pnpm i -g pnpm && pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing global 'pnpm' installation in 'build:site' script

Including pnpm i -g pnpm in the build:site script may be unnecessary since pnpm is already being used to run the script. Installing packages globally within scripts can cause issues in environments with restricted permissions.

Apply this diff to update the script:

-"build:site": "pnpm i -g pnpm && pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",
+"build:site": "pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"build:site": "pnpm i -g pnpm && pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",
"build:site": "pnpm build:vite-import && pnpm build:virtual-template && pnpm -C examples/sites build",

"release:aurora": "pnpm -C internals/cli release:aurora",
"// ---------- 使用pnpm批量发布npm包 ----------": "",
"pub2": "pnpm --filter=\"./packages/dist2/**\" publish --tag v2-latest --no-git-checks --access=public",
Expand Down
Loading