Skip to content

Upgrade to wombat 3.8.11 #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Upgrade to wombat 3.8.11 #257

wants to merge 3 commits into from

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Apr 29, 2025

Fix #256

I also had to disable an unrelated failing test, see #258

@benoit74 benoit74 self-assigned this Apr 29, 2025
@benoit74 benoit74 marked this pull request as draft April 29, 2025 07:34
@benoit74 benoit74 marked this pull request as ready for review April 29, 2025 08:13
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fef63f8) to head (d30545f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         2455      2455           
  Branches       331       331           
=========================================
  Hits          2455      2455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74
Copy link
Collaborator Author

I realized I forgot the CHANGELOG entry, just added it and forced push

@benoit74
Copy link
Collaborator Author

Looks like Github broke right in the middle of the merge ... let's see if it achieves to recover. At least code in merged in Git.

@benoit74 benoit74 closed this Apr 29, 2025
@benoit74
Copy link
Collaborator Author

Trust me, this is merged ...

@benoit74 benoit74 deleted the upgrade-wombat branch April 29, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade wombat to 3.8.9 (or more recent)
2 participants