Add JS rewriting rule to ignore import function rewriting #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #255
For some reason, we were missing one JS rewriting rule implemented in wabac: https://github.com/webrecorder/wabac.js/blame/364b6e2d329f5ff92d680b482ec4f7e2036d6603/src/rewrite/jsrewriter.ts#L181
This has been put into wabac.js at webrecorder/wabac.js#164 ; looks like we missed the opportunity to back-port this into our rewriting code. Most probably because we only focus on fuzzy rules and forgot to also consider these JS rewriting rules. I've updated the release checklist to also check this file.
I've also checked all other rules in this file and realized that we missed some other changes, not linked to this bug but still worth to include, so they are in a distinct commit.
To be merged after #257