Revert "refactor: Update datafile-manager to use Async Storage implementation from utils (#508)" #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
suggested changes
Jul 23, 2020
| @@ -48,7 +49,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@optimizely/js-sdk-logging": "^0.1.0", | |||
| "@optimizely/js-sdk-utils": "^0.3.2", | |||
| "@optimizely/js-sdk-utils": "^0.2.0", | |||
There was a problem hiding this comment.
I think this dependency should stay at "^0.3.2"
There was a problem hiding this comment.
Updated it to the newly released 0.4.0
mjc1283
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit 9af51d8.
ReactNative Async Storage implementation was previosuly moved to Utils package in order to use it both in Datafile Manager and Event Processor. While testing the new offline storage in event processor, it was observed that event processor asked for installing react-native-community/async storage package even when run for node or browser. This was because we didn't have separate entrypoints in the utils package. It was decided to move react native async storage implementation to both datafile manager and event processor.
Test plan
All existing tests should pass