Skip to content

chore(contrib): Add PR template and commit message guidelines. #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2018
Merged

chore(contrib): Add PR template and commit message guidelines. #135

merged 3 commits into from
Nov 14, 2018

Conversation

rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Nov 6, 2018

Summary

  • Adds commit message guidelines in CONTRIBUTING.md.
  • Adds PR template for Github PRs.

@rashidsp
Copy link
Contributor Author

rashidsp commented Nov 6, 2018

Lint errors fixed in #136

@coveralls
Copy link

coveralls commented Nov 9, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 90c52c5 on rashid/amend-contributing-guidelines into 265d344 on master.

mikeproeng37
mikeproeng37 approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 8a80d21 into master Nov 14, 2018
@rashidsp rashidsp deleted the rashid/amend-contributing-guidelines branch January 9, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rashidsp @coveralls @mikeproeng37