Fix: Lint errors after rubocop update. #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
reviewed
Nov 6, 2018
lib/optimizely/helpers/validator.rb
Outdated
| if logger_valid?(logger) && level | ||
| logger.log(level, "#{Optimizely::Helpers::Constants::INPUT_VARIABLES[key.to_s.upcase]} is invalid") | ||
| end | ||
| logger.log(level, "#{Optimizely::Helpers::Constants::INPUT_VARIABLES[key.to_s.upcase]} is invalid") if logger_valid?(logger) && level |
There was a problem hiding this comment.
Hmm, I find this is harder to read than before, is that really one of our int rules? If so we should change it so that it won't complain about this. @apanzerj what are your thoughts on this kind of styling rule?
There was a problem hiding this comment.
Plz review the addressed change, it's also complying with rubocop rules.
mikeproeng37
reviewed
Nov 7, 2018
lib/optimizely/bucketer.rb
Outdated
| if variation_id == '' | ||
| @config.logger.log(Logger::DEBUG, 'Bucketed into an empty traffic range. Returning nil.') | ||
| end | ||
| @config.logger.log(Logger::DEBUG, 'Bucketed into an empty traffic range. Returning nil.') if variation_id == '' |
There was a problem hiding this comment.
Same comment here, is there a way to invert this relationship? Seems like it makes it harder to read
|
@rashidsp I would suggest that rather than modifying code or adding extra lines to comply with rubocop rule, ignore this particular rule in rubocop.yml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
0.60.0.