Skip to content

[FSSDK-11372] assign holdoutIds to feature flags #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Apr 21, 2025
Merged

[FSSDK-11372] assign holdoutIds to feature flags #578

merged 25 commits into from
Apr 21, 2025

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Mar 24, 2025 •
edited
Loading

Summary

  • Update the flag's dependent holdoutIds

Test plan

  • New test cases added

Issues

  • FSSDK-11372

@muzahidul-opti muzahidul-opti marked this pull request as ready for review April 8, 2025 15:57
@muzahidul-opti muzahidul-opti changed the title [FSSDK-11372] assign holdouts to feature flags [FSSDK-11372] assign holdoutIds to feature flags Apr 8, 2025
@muzahidul-opti muzahidul-opti requested a review from jaeopt April 8, 2025 16:05
jaeopt
jaeopt requested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's discuss options.

@muzahidul-opti muzahidul-opti requested a review from jaeopt April 9, 2025 18:24
jaeopt
jaeopt requested changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We need to add order enforcement as discussed.

@muzahidul-opti muzahidul-opti requested a review from jaeopt April 15, 2025 14:53
jaeopt
jaeopt requested changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change. It looks like we need to fix ordering.

@muzahidul-opti
Copy link
Contributor Author

I like the change. It looks like we need to fix ordering.
done

@muzahidul-opti muzahidul-opti requested a review from jaeopt April 16, 2025 12:18
jaeopt
jaeopt requested changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good! A few more clean up tips.

@muzahidul-opti muzahidul-opti requested a review from jaeopt April 18, 2025 15:17
jaeopt
jaeopt approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@muzahidul-opti muzahidul-opti merged commit 7c4fee7 into master Apr 21, 2025
19 of 22 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/FSSDK-11372 branch April 21, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt