Skip to content

Conversation

@eisenhauer
Copy link
Member

No description provided.

@eisenhauer eisenhauer requested a review from vicentebolea as a code owner June 10, 2024 18:20
@vicentebolea
Copy link
Collaborator

@eisenhauer I added tmp images to check that xrootd is installed correctly

@eisenhauer
Copy link
Member Author

Cool. Lets see how this goes...

@vicentebolea
Copy link
Collaborator

@eisenhauer find the temp images with xrootd.

@eisenhauer
Copy link
Member Author

@vicentebolea Hey Vicente! So current issue is that the XRootD server really doesn't want to run as root. It can be started as root and you can use the -R option to tell it another user or UID to run as, but "-R root" or "-R 0" are rejected. Are there github action options that we might use to help get around this? I.E. adding a user to the docker that we only use to run the Xrootd server?

Copy link
Member Author

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digging into the XRootD code here, this error means that getpwnam("daemon") didn't return anything... If you pass a numeric value it passes that to getpwuid().

@vicentebolea vicentebolea force-pushed the XrootDTesting branch 7 times, most recently from 3d64d01 to 3d7cab9 Compare June 20, 2024 21:36
@vicentebolea vicentebolea force-pushed the XrootDTesting branch 6 times, most recently from 5ce0a68 to dde8830 Compare July 16, 2024 00:59
@vicentebolea
Copy link
Collaborator

@eisenhauer the tests finally passes

@eisenhauer
Copy link
Member Author

Nice!

@eisenhauer
Copy link
Member Author

@vicentebolea Time to revive this PR and prepare to merge. I tried (badly) to update the CI to reflect changes since it was first done, but it likely needs you attention.

@vicentebolea
Copy link
Collaborator

do you need to re-do the docker images?

@eisenhauer
Copy link
Member Author

I'm actually not sure what you did before to get these to run. Temporary docker images? There were conflicts with master in some of the setup files that I tried to resolve, but perhaps incorrectly.

@eisenhauer
Copy link
Member Author

So I guess the goal is this: The non-CI stuff in here mostly just enables testing of the XRootD plugin. We'd like to test on one or more platform in CI, so we'd need xrootd installed. Doesn't have to be everywhere, but one or two places would be good.

@vicentebolea vicentebolea force-pushed the XrootDTesting branch 2 times, most recently from 144fc9c to 1c1f8a3 Compare August 19, 2024 20:24
@vicentebolea
Copy link
Collaborator

@eisenhauer the CI is ready, the 20.04 images now have xrootd.

@eisenhauer
Copy link
Member Author

Minor tweak to fix server args.

Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, looks good otherwise. After addressing the comemnts that makes sense to you I can remove the 'tmp' and we can merge this.

@vicentebolea
Copy link
Collaborator

@eisenhauer we are still having errors, let me know when the CI is green

@eisenhauer
Copy link
Member Author

@vicentebolea It looks like we're back to the user problem. In the manipulations, did we lose the bit that made this work?

vicentebolea
vicentebolea previously approved these changes Aug 20, 2024
@vicentebolea
Copy link
Collaborator

@eisenhauer lets squash-merge to get rid of all this fixup commits

@vicentebolea
Copy link
Collaborator

@eisenhauer images are pushed (without the tmp)

@eisenhauer eisenhauer enabled auto-merge (squash) August 20, 2024 20:49
@eisenhauer eisenhauer merged commit a810bb5 into ornladios:master Aug 20, 2024
@eisenhauer eisenhauer deleted the XrootDTesting branch August 20, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants