Making build with HDF5 more informative #4649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) display whether HDF5 is parallel or serial if present 2) the behaviour of ADIOS2_USE_HDF5=AUTO/TRUE is consoliated when HDF5 is present 3) FYI: SERIAL HDF5 compiles fine
guj
requested review from
pnorbert and
vicentebolea
and removed request for
vicentebolea
pnorbert
previously approved these changes
Oct 6, 2025
Contributor
Author
|
win2022 had many failed tests, not sure why. Any clue on that platform? |
eisenhauer
approved these changes
Oct 9, 2025
scottwittenburg
pushed a commit
to scottwittenburg/ADIOS2
that referenced
this pull request
Oct 27, 2025
* Two changes: 1) display whether HDF5 is parallel or serial if present 2) the behaviour of ADIOS2_USE_HDF5=AUTO/TRUE is consoliated when HDF5 is present 3) FYI: SERIAL HDF5 compiles fine * double check if hdf5 is PARALLEL if calling mpi flags * format fix * dealt with one C2057 error from windows * fix format * fixed format * more C2057 fixes * format * format again * fixed warning * format * fixed MSVC warnings * format * more format fix * missed another * fixed MSVC warnings * turned off VOL on win2022
| return true; | ||
| } | ||
|
|
||
| free(fullPath); |
Collaborator
There was a problem hiding this comment.
There appears to be a problem here (caught by rebasing #4666 on master today): fullPath is still used below, after this call to free it.
I'm not sure how this isn't causing any problems in CI. Maybe the function never gets called in CI? Or some early-return codepath above is always taken? Or NEVER is, in fact, defined?
Member
There was a problem hiding this comment.
It's in a failure path, likely never executed in CI...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is present
FYI: SERIAL HDF5 compiles fine