H5VolReadWrite: Do not use variable after memory is freed #4698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry I just saw the emails. Thanks Scott. You can remove the NEVER macros: e.g. printf("\n......... NOTE: unable to remove GROUP %s \n\n", fullPath); |
scottwittenburg
force-pushed
the
fix-use-after-free
branch
from
95965dd to
08a01f4
Compare
Collaborator
Author
|
@guj Thanks for the suggestion, I've updated it as you suggested. CI is all green now, if you are willing to approve, I'll merge and rebase my ci pr. |
Contributor
|
@vicentebolea can approve. I do not have permission |
eisenhauer
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue found by compiler warning newly emitted in #4666