Increase setup timeout for RMF integration test#115
Closed
luca-della-vedova wants to merge 2 commits intomainfrom
Closed
Increase setup timeout for RMF integration test#115luca-della-vedova wants to merge 2 commits intomainfrom
luca-della-vedova wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
2 tasks
Member
Author
|
Fixed by #121 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been seeing increased flakiness on RMF integration tests for some time.
I looked at the logs / tried to reproduce locally and I'm fairly confident it's due to the fact that our worlds use very large models (depot itself is almost 80MB!) and we expect the bringup, which includes downloading all the models, in 60 seconds.
I tried on a very high power machine and downloading models seems to add a good chunk of time to the integration test, I also noticed that gazebo adds some printouts when it finished downloading models and our CI times out and fails before the printout is logged.
Trying to double the timeout to see if it helps.