Skip to content

Remove ccache from CI#121

Merged
aaronchongth merged 1 commit intomainfrom
luca/remove_ccache
Aug 19, 2025
Merged

Remove ccache from CI#121
aaronchongth merged 1 commit intomainfrom
luca/remove_ccache

Conversation

@luca-della-vedova
Copy link
Copy Markdown
Member

@luca-della-vedova luca-della-vedova commented Aug 19, 2025

Do you know why CI has been flaky for ages?

Because specifying --cmake-args after the mixin overwrote the release mixin and we were building in debug mode.

There.

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@luca-della-vedova luca-della-vedova marked this pull request as ready for review August 19, 2025 07:18
Copy link
Copy Markdown
Collaborator

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@aaronchongth aaronchongth merged commit eec64a5 into main Aug 19, 2025
6 checks passed
@Yadunund
Copy link
Copy Markdown
Member

Why remove ccahce? Wouldn't this lead to slower builds?

@luca-della-vedova luca-della-vedova deleted the luca/remove_ccache branch August 20, 2025 01:40
@luca-della-vedova
Copy link
Copy Markdown
Member Author

We can reintroduce it by using the mixin but I don't think it actually does anything so I'm a bit puzzled at why it was there in the first place.

Ccache is supposed to speed up recompilation but when we are in CI we start from a blank image so we need to compile everything from scratch anyway and ccache doesn't do anything.

To prove you can see the various attempts of this PR's CI that take around 23 mins, that is consistent with other PRs CI.

I realized I forgot to remove the ccache CI step in the cleanup but that seems to take 1 second anyway

@aaronchongth
Copy link
Copy Markdown
Collaborator

Yeah looking at the build-times, I think we weren't using cccahe together with the action/cache properly.

From some quick searches, it looks like the steps required to restore the cache is a little more convoluted than what we were doing. I'd be happy to take a crack at it when I'm done with the rmw migration, but hopefully by then the compilation times would have sped up enough to not be an issue already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants