Skip to content

Revert #553 (WarmUpBlockProvider deferred thread start): hangs the sampling profiler on Windows - #555

Closed
Jarred-Sumner wants to merge 1 commit into
mainfrom
claude/revert-553-warmup-start-threshold
Closed

Jarred-Sumner wants to merge 1 commit into
mainfrom
claude/revert-553-warmup-start-threshold

Revert "WarmUpBlockProvider: start the helper thread after 64 block r…

61308f2
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 3, 2026 in 17m 40s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 1
Severity File:Line Issue
🟣 Pre-existing Source/JavaScriptCore/heap/FastMallocAlignedMemoryAllocator.cpp:264 Pre-existing: this revert moves the *first* helper-thread spawn back to VM bring-up, but 'Thread::create' is still issue