Repository navigation
Revert #553 (WarmUpBlockProvider deferred thread start): hangs the sampling profiler on Windows #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Revert #553 (WarmUpBlockProvider deferred thread start): hangs the sampling profiler on Windows #555
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟣 Pre-existing: this revert moves the first helper-thread spawn back to VM bring-up, but
Thread::createis still issued fromtryAllocateAlignedMemoryon the mutator every time the helper has idle-timed-out (10 s of no block requests) and a new block is needed, so a long-running profiled process on Windows can still hit the same sampler self-deadlock the PR is reverting to avoid. Fix: never spawn the helper from the allocator — restart it from a safepoint, or drop the idle timeout so the OS thread stays alive once created.Extended reasoning...
After the supply is filled and block demand stops,
AutomaticThreadwaitswarmUpMarkedBlockIdleTimeout(default 10 s),WarmUpThread::shouldSleep()seesm_demandSinceIdleCheckclear, and the OS thread exits viastopForTimeout→threadIsStopping(m_hasUnderlyingThread=false, m_phase=Stopped, m_blocks freed). The next MarkedBlock request reaches line 264 →singleton().tryTake()finds the supply empty and phase≠StandingDown →m_condition->notifyOne()→AutomaticThreadCondition::notifyOnefinds!hasUnderlyingThread()→AutomaticThread::start()→WTF::Thread::create(), all on the JS mutator inside the allocation slow path with user code on the stack. That is the exact call the PR description names as the Windows self-deadlock trigger whenSamplingProfilersuspends the JS thread mid thread-creation. The base branch has this same restart path (plus the 64th-block path the revert removes), so this is an unfixed sibling of the bug being addressed rather than a regression; a steady-state heap easily goes 10 s without needing a fresh MarkedBlock, so the window is…Verification: pre-existing — the idle-timeout restart path is untouched by this diff and exists identically on the base branch (and pre-#553), so merging makes nothing worse; the specific CI test the PR targets completes in well under 10 s and won't hit it. Mechanism verified: - FastMallocAlignedMemoryAllocator.cpp:123 — WarmUpThread is constructed with timeout… | pre-existing — the idle-timeout re-spawn path…