emit 206 Partial Content only for partial response
#1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlamsl
commented
Dec 27, 2022
| expect(await response.text()).toBe("such fail"); | ||
| } | ||
| expect(response.status).toBe(500); | ||
| expect(await response.text()).toBe("PASS"); |
Contributor
Author
There was a problem hiding this comment.
This test fails to begin with − so I just fix up the expected results based on description, which remains to fail but at least it's a good starting point.
| while (true) { | ||
| try { | ||
| serverOptions.port = port++; | ||
| server = serve(serverOptions); |
Collaborator
There was a problem hiding this comment.
We could use server.reload here and then an afterAll to terminate the server at the very end
| var response: *JSC.WebCore.Response = this.response_ptr.?; | ||
| var status = response.statusCode(); | ||
| var needs_content_range = this.needs_content_range; | ||
| var needs_content_range = this.needs_content_range and this.sendfile.remain < this.blob.size(); |
Collaborator
There was a problem hiding this comment.
sendfile is initialized to undefined, so we need to be extremely careful when it is accessed
I think this is okay because needs_content_range is initialized to false
Contributor
Author
There was a problem hiding this comment.
The next line does:
const size = if (needs_content_range)
this.sendfile.remain
else
this.blob.size();Hence I won't be introducing any new NPE here 😏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1668