Skip to content

emit 206 Partial Content only for partial response #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 1 commit into from
Dec 28, 2022
Merged

emit 206 Partial Content only for partial response #1670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bun.js/api/server.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2138,7 +2138,7 @@ fn NewRequestContext(comptime ssl_enabled: bool, comptime debug_mode: bool, comp
pub fn renderMetadata(this: *RequestContext) void {
var response: *JSC.WebCore.Response = this.response_ptr.?;
var status = response.statusCode();
var needs_content_range = this.needs_content_range;
var needs_content_range = this.needs_content_range and this.sendfile.remain < this.blob.size();
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sendfile is initialized to undefined, so we need to be extremely careful when it is accessed

I think this is okay because needs_content_range is initialized to false

Copy link
Contributor Author

@alexlamsl alexlamsl Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next line does:

const size = if (needs_content_range)
    this.sendfile.remain
else
    this.blob.size();

Hence I won't be introducing any new NPE here 😏


const size = if (needs_content_range)
this.sendfile.remain
Expand Down
Loading