fix(transformer/module_runner): hoist export #10347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-transformer
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
hi-ogawa
changed the title
hi-ogawa
force-pushed
the
03-21-feat_transformer_module_runner_hoist_export
branch
from
0bbf4ec to
bc57d86
Compare
CodSpeed Instrumentation Performance ReportMerging #10347 will not alter performanceComparing Summary
|
hi-ogawa
force-pushed
the
03-21-feat_transformer_module_runner_hoist_export
branch
3 times, most recently
from
eb44a47 to
93bb323
Compare
Dunqing
reviewed
Apr 11, 2025
hi-ogawa
force-pushed
the
03-21-feat_transformer_module_runner_hoist_export
branch
from
b2022cf to
de5df51
Compare
Dunqing
approved these changes
Apr 14, 2025
Merge activity
|
Aligning with vitejs/vite#18983 I manually verified the test case output matches with the ones in Vite repo. ~I add a new TODO about "export default" getter, but this difference existed already. I plan to fix this separately.~ (EDIT: It turned out Vite's transform is the wrong one vitejs/vite#19834.)
graphite-app
bot
force-pushed
the
03-21-feat_transformer_module_runner_hoist_export
branch
from
de5df51 to
1ff75bc
Compare
graphite-app
bot
deleted the
03-21-feat_transformer_module_runner_hoist_export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning with vitejs/vite#18983
I manually verified the test case output matches with the ones in Vite repo.
I add a new TODO about "export default" getter, but this difference existed already. I plan to fix this separately.(EDIT: It turned out Vite's transform is the wrong one vitejs/vite#19834.)