Skip to content

fix(transformer/module_runner): fix execution order of re-export #10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Apr 11, 2025

Aligning with vitejs/vite#19841

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Apr 11, 2025
Copy link
Contributor Author

hi-ogawa commented Apr 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Instrumentation Performance Report

Merging #10362 will not alter performance

Comparing 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export (6c115c7) with main (4c316a5)

Summary

✅ 36 untouched benchmarks

@hi-ogawa hi-ogawa force-pushed the 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export branch from 9c93aee to 9af67f1 Compare April 11, 2025 09:27
@graphite-app graphite-app bot changed the base branch from 03-21-feat_transformer_module_runner_hoist_export to graphite-base/10362 April 14, 2025 02:36
@graphite-app graphite-app bot force-pushed the graphite-base/10362 branch from de5df51 to 1ff75bc Compare April 14, 2025 02:42
@graphite-app graphite-app bot force-pushed the 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export branch from 9af67f1 to 90c6119 Compare April 14, 2025 02:42
@graphite-app graphite-app bot changed the base branch from graphite-base/10362 to main April 14, 2025 02:43
@graphite-app graphite-app bot force-pushed the 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export branch from 90c6119 to 18ce3a2 Compare April 14, 2025 02:43
@hi-ogawa hi-ogawa force-pushed the 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export branch from 18ce3a2 to 932a66c Compare April 23, 2025 07:08
@hi-ogawa hi-ogawa changed the title fix(transformer/module_runner): fix execution order of re-export fix(transformer/module_runner): fix execution order of re-export and export default live binding Apr 23, 2025
@hi-ogawa hi-ogawa changed the title fix(transformer/module_runner): fix execution order of re-export and export default live binding fix(transformer/module_runner): fix execution order of re-export Apr 23, 2025
@hi-ogawa hi-ogawa force-pushed the 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export branch from eb16aa2 to 8a49752 Compare April 23, 2025 09:21
@hi-ogawa hi-ogawa marked this pull request as ready for review April 23, 2025 09:28
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 23, 2025
Copy link
Contributor

graphite-app bot commented Apr 23, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export branch from 8a49752 to 6c115c7 Compare April 23, 2025 10:07
@graphite-app graphite-app bot merged commit 6c115c7 into main Apr 23, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-11-fix_transformer_module_runner_fix_execution_order_of_re-export branch April 23, 2025 10:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 23, 2025
Boshen added a commit that referenced this pull request Apr 23, 2025
## [0.66.0] - 2025-04-23

### Features

- 7d5ad7d parser: Report error when `import type { type }` is used
(#10528) (camc314)
- 6e40fac parser: Report error when `export type { type }` is used
(#10524) (camc314)

### Bug Fixes

- 43ad4e9 ast: Box `this_param` in `TSCallSignatureDeclaration` (#10558)
(Yuji Sugiura)
- 8eb3c0a ast/estree: Fix raw deser for `FormalParameter` (#10548)
(overlookmotel)
- 3ebf220 codegen: Generate missing `type` in `export type {} from
'mod'` (#10539) (Boshen)
- f19b287 estree: Add `TSParameterProperty` (#10534) (Yuji Sugiura)
- 7284f16 isolated-declarations: Leading comments of
`ExportDefaultDeclaration` and `TSExportAssignment` appear in incorrect
places (#10559) (Dunqing)
- 4c316a5 isolated_declarations: Fix broken snapshot files (#10561)
(Boshen)
- 84742d8 transformer/module_runner: Fix export default live binding
(#10560) (hi-ogawa)
- 6c115c7 transformer/module_runner: Fix execution order of re-export
(#10362) (hi-ogawa)
- b9d84b0 transformer/typescript: Remove `StringLiteral::raw` when
rewriting extensions (#10554) (overlookmotel)

### Performance

- 6a045c8 codegen: Speed up printing `Directive`s (#10551)
(overlookmotel)
- 3418ae5 transformer/class-properties: Re-use
`InstanceInitializerVisitor` (#10543) (overlookmotel)
- 7fcf0ac transformer/typescript: Reduce allocations renaming extensions
(#10555) (overlookmotel)

### Documentation

- 1a9530c transformer/class-properties: Fix typo (#10542)
(overlookmotel)

### Refactor

- 7e71282 transformer/class-properties: Correct outdated comment
(#10546) (overlookmotel)
- 596978b transformer/class-properties: Simplify to get `constructor`
method only once (#10493) (Dunqing)
- f13fe0a transformer/class-properties: Defer re-parenting initializers
scopes until all instance properties are transformed (#10495) (Dunqing)
- c83dad6 transformer/class-properties: Streamline handling scope of
instance property initializer (#10492) (Dunqing)

### Styling

- e10dfc8 traverse: Remove excess whitespace (#10544) (overlookmotel)

### Testing

- 227febf allocator: Ignore a slow doc test (#10521) (Dunqing)
- 14bb2be codegen: Add more tests for strings (#10552) (overlookmotel)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants