Conversation
taspelund
added a commit
that referenced
this pull request
May 9, 2026
Brings in 15 commits from main, the most substantive being: - #730 [mg-admin-api] fix v2/v3 MessageHistory and related types - #715 Update Rust crate rust to v1.95.0 (with clippy::useless_conversion fix) - #710 dropshot 0.7.1 - #707 opte update - assorted dep bumps (tokio, clap, oxnet, uuid, oxide-tokio-rt, openssl, reqwest, libc) and lock-file maintenance Notes on conflict resolution: - mg-types/versions/src/ipv6_basic/bgp.rs: incorporated #730's v2 MessageHistory/MessageHistoryEntry/Message/UpdateMessage types and their From-from-live conversions, but retargeted imports through bgp-types-versions and rdb-types-versions to preserve the leaf-crate rule cleanup from this branch (the commit message on #730 calls out that this is a known short-term shortcut). Same approach for mg-types/versions/src/mp_bgp/bgp.rs (where #730 added a v4 MessageHistoryResponse). - mg-types/versions/Cargo.toml: kept the leaf-rule-clean dep set (bgp-types-versions, rdb-types-versions) and added chrono per #730's need for chrono::DateTime in MessageHistoryEntry. - bgp-types/versions/src/ipv6_basic/session.rs: promoted MessageHistoryEntry's timestamp/message/connection_id fields back from pub(crate) to pub. The migration in this branch had inadvertently tightened the visibility (they were pub on main); #730 needs pub access for its From impl. - bgp-types/versions/src/impls/messages.rs: applied #715's clippy::useless_conversion fix at the migrated location (impl OpenMessage::get_capabilities), which is where the original bgp::messages code now lives after our migration. - bgp/src/messages.rs and bgp/src/session.rs: took our side; #715's clippy fix applies to the migrated location, not the bgp-local free-fn replacements. - mg-api/src/lib.rs: kept our use bfd_types::{BfdPeerConfig, BfdPeerInfo} import; took main's mg_types_versions::{latest, v1, v2, v4, v5} (gaining v4 for #730's MessageHistoryResponse v4 endpoint). - Cargo.lock: regenerated. Verified: cargo check --workspace --all-features clean, cargo clippy --workspace --all-features --no-deps clean (only pre-existing lab/ warnings), cargo run -p xtask -- openapi check shows all 10 documents fresh (byte-identical schemas), 152/152 tests pass on bgp + bfd + *-types-versions crates. Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.7.0→0.7.10.7.0→0.7.1Release Notes
oxidecomputer/dropshot-api-manager (dropshot-api-manager)
v0.7.1Compare Source
Added
Normalize WebSocket response JSON schema changes between Dropshot 0.16 and 0.17. (The changes are wire-compatible but the JSON schema is different.)
Configuration
📅 Schedule: (in timezone America/Los_Angeles)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate.