Conversation
Rust 1.95.0 clippy flags result.extend(caps.clone().into_iter()) since extend already accepts IntoIterator. Signed-off-by: Trey Aspelund <t.k.aspelund@gmail.com>
taspelund
force-pushed
the
renovate/rust-1.x
branch
from
86e91bb to
6b5d718
Compare
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
taspelund
added a commit
that referenced
this pull request
May 9, 2026
Brings in 15 commits from main, the most substantive being: - #730 [mg-admin-api] fix v2/v3 MessageHistory and related types - #715 Update Rust crate rust to v1.95.0 (with clippy::useless_conversion fix) - #710 dropshot 0.7.1 - #707 opte update - assorted dep bumps (tokio, clap, oxnet, uuid, oxide-tokio-rt, openssl, reqwest, libc) and lock-file maintenance Notes on conflict resolution: - mg-types/versions/src/ipv6_basic/bgp.rs: incorporated #730's v2 MessageHistory/MessageHistoryEntry/Message/UpdateMessage types and their From-from-live conversions, but retargeted imports through bgp-types-versions and rdb-types-versions to preserve the leaf-crate rule cleanup from this branch (the commit message on #730 calls out that this is a known short-term shortcut). Same approach for mg-types/versions/src/mp_bgp/bgp.rs (where #730 added a v4 MessageHistoryResponse). - mg-types/versions/Cargo.toml: kept the leaf-rule-clean dep set (bgp-types-versions, rdb-types-versions) and added chrono per #730's need for chrono::DateTime in MessageHistoryEntry. - bgp-types/versions/src/ipv6_basic/session.rs: promoted MessageHistoryEntry's timestamp/message/connection_id fields back from pub(crate) to pub. The migration in this branch had inadvertently tightened the visibility (they were pub on main); #730 needs pub access for its From impl. - bgp-types/versions/src/impls/messages.rs: applied #715's clippy::useless_conversion fix at the migrated location (impl OpenMessage::get_capabilities), which is where the original bgp::messages code now lives after our migration. - bgp/src/messages.rs and bgp/src/session.rs: took our side; #715's clippy fix applies to the migrated location, not the bgp-local free-fn replacements. - mg-api/src/lib.rs: kept our use bfd_types::{BfdPeerConfig, BfdPeerInfo} import; took main's mg_types_versions::{latest, v1, v2, v4, v5} (gaining v4 for #730's MessageHistoryResponse v4 endpoint). - Cargo.lock: regenerated. Verified: cargo check --workspace --all-features clean, cargo clippy --workspace --all-features --no-deps clean (only pre-existing lab/ warnings), cargo run -p xtask -- openapi check shows all 10 documents fresh (byte-identical schemas), 152/152 tests pass on bgp + bfd + *-types-versions crates. Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.94.1→1.95.0Release Notes
rust-lang/rust (rust)
v1.95.0Compare Source
===========================
Language
if letguards on match armsirrefutable_let_patternslint no longer lints on let chainsCompiler
--remap-path-scopefor controlling the scoping of how paths get remapped in the resulting binaryPlatform Support
powerpc64-unknown-linux-muslto Tier 2 with host toolsaarch64-apple-tvosto Tier 2aarch64-apple-tvos-simto Tier 2aarch64-apple-watchosto Tier 2aarch64-apple-watchos-simto Tier 2aarch64-apple-visionosto Tier 2aarch64-apple-visionos-simto Tier 2Refer to Rust's platform support page
for more information on Rust's tiered platform support.
Libraries
thread::scope: document how join interacts with TLS destructorsstr::containson aarch64 targets withneontarget feature enabled by defaultStabilized APIs
MaybeUninit<[T; N]>: From<[MaybeUninit<T>; N]>MaybeUninit<[T; N]>: AsRef<[MaybeUninit<T>; N]>MaybeUninit<[T; N]>: AsRef<[MaybeUninit<T>]>MaybeUninit<[T; N]>: AsMut<[MaybeUninit<T>; N]>MaybeUninit<[T; N]>: AsMut<[MaybeUninit<T>]>[MaybeUninit<T>; N]: From<MaybeUninit<[T; N]>>Cell<[T; N]>: AsRef<[Cell<T>; N]>Cell<[T; N]>: AsRef<[Cell<T>]>Cell<[T]>: AsRef<[Cell<T>]>bool: TryFrom<{integer}>AtomicPtr::updateAtomicPtr::try_updateAtomicBool::updateAtomicBool::try_updateAtomicIn::updateAtomicIn::try_updateAtomicUn::updateAtomicUn::try_updatecfg_select!mod core::rangecore::range::RangeInclusivecore::range::RangeInclusiveItercore::hint::cold_path<*const T>::as_ref_unchecked<*mut T>::as_ref_unchecked<*mut T>::as_mut_uncheckedVec::push_mutVec::insert_mutVecDeque::push_front_mutVecDeque::push_back_mutVecDeque::insert_mutLinkedList::push_front_mutLinkedList::push_back_mutLayout::dangling_ptrLayout::repeatLayout::repeat_packedLayout::extend_packedThese previously stable APIs are now stable in const contexts:
fmt::from_fnControlFlow::is_breakControlFlow::is_continueRustdoc
Compatibility Notes
$cratewithout renaming, i.e.use $crate::{self};, is now no longer permitted due to stricter error checking forselfimports.In very rare cases, this may cause compilation errors due to bytes from parts of a pointer ending up in the padding bytes of a
constorstatic.ambiguous_glob_imported_traitsis now reported when using an ambiguously glob imported traitEq::assert_receiver_is_total_eqand emit future compatibility warnings on manual impls#[non_exhaustive]enum now reads the discriminant, even if the enum has only one variant. This can cause closures to capture values that they previously wouldn't.mut refandmut ref mutpatterns, part of the unstable Match Ergonomics 2024 RFC, were accidentally allowed on stable within struct pattern field shorthand. These patterns are now correctly feature-gated as unstable in this position.-Z unstable-optionsto use. Previously, they could not be used without the standard library, which has no stable build mechanism. In preparation for thebuild-stdproject adding that support, JSON target specs are being proactively gated to ensure they remain unstable even ifbuild-stdis stabilized. Cargo now includes the-Z json-target-specCLI flag to automatically pass-Z unstable-optionsto the compiler when needed. See #150151, #151534, and rust-lang/cargo#16557.#[feature]attributes on invalid targets are now checkedInternal Changes
These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.
Configuration
📅 Schedule: (in timezone America/Los_Angeles)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.