Skip to content

Make disk location required in sled-agent inventory and Nexus - #11628

Draft
smklein wants to merge 2 commits into
topo-disk-scanfrom
required-disk-location
Draft

smklein wants to merge 2 commits into
topo-disk-scanfrom
required-disk-location

merge

9d0a7a4
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Nov 2, 2026 in 4m 51s

Code review found 1 potential issue

Found 2 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit nexus/db-queries/src/db/datastore/inventory.rs:3491 Right after an upgrade, 'omdb nexus sleds expunge-disk' can skip its "disk is PRESENT" safety prompt for a disk that is