Add sp version info to omdb nexus update-status
#8517
Conversation
|
Some local testing with |
| Ok(()) | ||
| } | ||
|
|
||
| fn print_zones(zones: impl Iterator<Item = (SledUuid, Vec<ZoneStatus>)>) { |
There was a problem hiding this comment.
This was all just moved but didn't change.
| println!("{}", table); | ||
| } | ||
|
|
||
| fn print_sps(sps: impl Iterator<Item = (String, SpStatus)>) { |
| slot0_version: String, | ||
| slot0_git_commit: String, | ||
| slot1_version: String, | ||
| slot1_git_commit: String, |
There was a problem hiding this comment.
Should we also include the system version associated with each of these SP versions (if we know it)?
IIRC for zones, the "version" we report is based on mapping the hash reported in inventory that is then mapped back to a system version (from a TUF repo). In the SP case, these versions are reported by the SP, but they're hubris release versions, and have no direct tie to a system version, right? So to know whether an update is complete or in progress, the consumer of this would have to know or find what hubris versions of different artifacts are present in the new repo. But I think Nexus already knows this and could include it for us to show here?
There was a problem hiding this comment.
🤦 Hmm, Should I just return the actual version if known? No real need for the other versions now that I think about it.
There was a problem hiding this comment.
I made the change to only include the TUF repo version in 3601261
| ); | ||
| } | ||
| } | ||
| if let Some(new) = new.tuf_repo() { |
There was a problem hiding this comment.
I think it's possible (albeit unlikely) SP versions don't change between releases - maybe put this one before checking old, so we report the newer if it matches both?
There was a problem hiding this comment.
Good idea! One other thing, is that testing this with omicron-dev does not seem to be doing what I expect. I also changed to parse the ArtifactVersion in case to_string was not symmetric with parse. Didn't make a difference. I think this is likely just an artifact of my test environment, but can't be sure without testing on a4x2 or a racklette.
There was a problem hiding this comment.
Changed in dce506f
andrewjstone
force-pushed
the
update-status-sp-version-info
branch
from
f4187f8 to
dce506f
Compare
Fixes #8485