fix(Section): flatten CardList top radius inside SectionCard#8053
Open
Abdeltoto wants to merge 1 commit intopalantir:developfrom
Open
fix(Section): flatten CardList top radius inside SectionCard#8053Abdeltoto wants to merge 1 commit intopalantir:developfrom
Abdeltoto wants to merge 1 commit intopalantir:developfrom
Conversation
Bordered CardList keeps the default Card border-radius on its outer wrapper, which looked wrong under the section header (rounded top + divider clash). Zero out the top radii when the list is a direct child of SectionCard. Fixes palantir#7841. Made-with: Cursor
Generate changelog in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7841
Checklist
Changelog
Unreleased entry:
packages/core/changelog/@unreleased/pr-7841-section-cardlist.yml(type: fix).Changes proposed in this pull request
When a bordered
CardListis nested in aSectionCard, its outer wrapper is still aCardwith the defaultborder-radius, which looked wrong under the section header (rounded top corners and divider clash). This change setsborder-top-left-radiusandborder-top-right-radiusto0for a borderedCardListthat is a direct child ofSectionCard.Reviewers should focus on
Visual check: Docs → CardList → Interactive Playground, enable Use Section container (bordered is forced on). Confirm the list lines up cleanly with the section header in light and dark theme.