Skip to content

fix(Section): flatten CardList top radius inside SectionCard #8053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abdeltoto wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(Section): flatten CardList top radius inside SectionCard #8053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/changelog/@unreleased/pr-7841-section-cardlist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: fix
fix:
description: Remove rounded top corners on bordered CardList when nested in SectionCard (#7841).
links:
- https://github.com/palantir/blueprint/issues/7841
7 changes: 7 additions & 0 deletions packages/core/src/components/section/_section.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ $section-card-padding-compact: $pt-spacing * 4 !default;
border-color: $pt-dark-divider-white;
}
}

// CardList uses a bordered outer Card that keeps the default Card border-radius; flush the top edge with the
// section header divider so we do not get rounded corners or a stray top border line on the first row (#7841).
> .#{$ns}-card.#{$ns}-card-list.#{$ns}-card-list-bordered {
border-top-left-radius: 0;
border-top-right-radius: 0;
}
}

&.#{$ns}-section-collapsed {
Expand Down