Skip to content

ohlc documentation #31919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dequadras opened this issue Feb 12, 2020 · 2 comments · Fixed by #31941
Closed

ohlc documentation #31919

dequadras opened this issue Feb 12, 2020 · 2 comments · Fixed by #31941
Labels
Docs good first issue

Comments

@dequadras
Copy link
Contributor

The documentation for ohlc is missleading. In https://pandas.pydata.org/pandas-docs/stable/reference/groupby.html The following doc appears, which probably references the docstring in the code.
image

A sentence like Computes open, high, low and close values, excluding missing values is probably more complete.
@MarcoGorelli
Copy link
Member

MarcoGorelli commented Feb 12, 2020 •
edited
Loading

Thanks @dequadras

Are you interested in submitting a pull request? If so, see the contributing guide for how to get started

@dequadras
Copy link
Contributor Author

Sure!

@WillAyd WillAyd added this to the Contributions Welcome milestone Feb 12, 2020
@dequadras dequadras mentioned this issue Feb 13, 2020
Merged
2 tasks
WillAyd pushed a commit that referenced this issue Feb 15, 2020
@dequadras
DOC: update ohlc docstring so that it reflects the real use #31919 (#…
2aa9cb9 
…31941)
roberthdevries pushed a commit to roberthdevries/pandas that referenced this issue Mar 2, 2020
@dequadras @roberthdevries
DOC: update ohlc docstring so that it reflects the real use pandas-de…
c03a396 
…v#31919 (pandas-dev#31941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC: update ohlc docstring so that it reflects the real use #31919
3 participants
@WillAyd @dequadras @MarcoGorelli